Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: runtime/vm/assembler_mips.cc

Issue 2463083002: Remove default monomorphic check code from functions and stubs that do not need it. (Closed)
Patch Set: address comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // NOLINT 5 #include "vm/globals.h" // NOLINT
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/longjump.h" 9 #include "vm/longjump.h"
10 #include "vm/runtime_entry.h" 10 #include "vm/runtime_entry.h"
(...skipping 842 matching lines...) Expand 10 before | Expand all | Expand 10 after
853 void Assembler::LeaveStubFrame() { 853 void Assembler::LeaveStubFrame() {
854 LeaveDartFrame(); 854 LeaveDartFrame();
855 } 855 }
856 856
857 857
858 void Assembler::LeaveStubFrameAndReturn(Register ra) { 858 void Assembler::LeaveStubFrameAndReturn(Register ra) {
859 LeaveDartFrameAndReturn(ra); 859 LeaveDartFrameAndReturn(ra);
860 } 860 }
861 861
862 862
863 void Assembler::NoMonomorphicCheckedEntry() {
864 buffer_.Reset();
865 break_(0);
866 break_(0);
867 break_(0);
868 ASSERT(CodeSize() == Instructions::kCheckedEntryOffset);
869 }
870
871
872 // T0 receiver, S5 guarded cid as Smi 863 // T0 receiver, S5 guarded cid as Smi
873 void Assembler::MonomorphicCheckedEntry() { 864 void Assembler::MonomorphicCheckedEntry() {
865 ASSERT(has_single_entry_point_);
866 has_single_entry_point_ = false;
874 bool saved_use_far_branches = use_far_branches(); 867 bool saved_use_far_branches = use_far_branches();
875 set_use_far_branches(false); 868 set_use_far_branches(false);
876 869
877 Label have_cid, miss; 870 Label have_cid, miss;
878 Bind(&miss); 871 Bind(&miss);
879 lw(T9, Address(THR, Thread::monomorphic_miss_entry_offset())); 872 lw(T9, Address(THR, Thread::monomorphic_miss_entry_offset()));
880 jr(T9); 873 jr(T9);
881 874
882 Comment("MonomorphicCheckedEntry"); 875 Comment("MonomorphicCheckedEntry");
883 ASSERT(CodeSize() == Instructions::kCheckedEntryOffset); 876 ASSERT(CodeSize() == Instructions::kCheckedEntryOffset);
(...skipping 511 matching lines...) Expand 10 before | Expand all | Expand 10 after
1395 Label stop; 1388 Label stop;
1396 b(&stop); 1389 b(&stop);
1397 Emit(reinterpret_cast<int32_t>(message)); 1390 Emit(reinterpret_cast<int32_t>(message));
1398 Bind(&stop); 1391 Bind(&stop);
1399 break_(Instr::kStopMessageCode); 1392 break_(Instr::kStopMessageCode);
1400 } 1393 }
1401 1394
1402 } // namespace dart 1395 } // namespace dart
1403 1396
1404 #endif // defined TARGET_ARCH_MIPS 1397 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/assembler_mips.h ('k') | runtime/vm/assembler_x64.h » ('j') | runtime/vm/object.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698