Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2463063002: [wasm] Fix br_table in the wasm interpreter to use varuint32. (Closed)

Created:
4 years, 1 month ago by ahaas
Modified:
4 years, 1 month ago
Reviewers:
tizer, rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix br_table in the wasm interpreter to use varuint32. The wasm interpreter crashed because it interpreted the table of br_table as a table of uint8, but according to the spec it is a table of varint32. Therefore the wasm interpreter misinterpreted 0x80 0x00 as 128 and not as 0, which caused a crash. R=tizer@chromium.org BUG=chromium:660262 TEST=cctest/test-run-wasm/RunWasmInterpreted_Regression_660262 Committed: https://crrev.com/a3b77d560e245ee04cdc254e033ff29e55a7cf86 Cr-Commit-Position: refs/heads/master@{#40708}

Patch Set 1 #

Patch Set 2 : signed unsigned mismatch #

Patch Set 3 : Remove unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M src/wasm/wasm-interpreter.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
ahaas
4 years, 1 month ago (2016-10-31 15:39:43 UTC) #1
rossberg
lgtm
4 years, 1 month ago (2016-11-02 12:27:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463063002/40001
4 years, 1 month ago (2016-11-02 17:04:43 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-02 17:06:47 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:19:47 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a3b77d560e245ee04cdc254e033ff29e55a7cf86
Cr-Commit-Position: refs/heads/master@{#40708}

Powered by Google App Engine
This is Rietveld 408576698