Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: device/usb/BUILD.gn

Issue 246303005: Make GN's "check" run cleanly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« crypto/BUILD.gn ('K') | « crypto/BUILD.gn ('k') | net/BUILD.gn » ('j') | net/dns/host_resolver_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/usb/BUILD.gn
diff --git a/device/usb/BUILD.gn b/device/usb/BUILD.gn
index 428a7172d6ab93c66b0f6cfd4b7dc15990bb57c4..e3427b2979346084e8f2d596c83d8ed0bc95bb3b 100644
--- a/device/usb/BUILD.gn
+++ b/device/usb/BUILD.gn
@@ -28,7 +28,5 @@ action("usb_device_ids") {
]
# Only the device_usb target can depend on us.
- # TODO(brettw) uncomment this when visibility is implemented in the pushed
- # GN binary.
- #visibility = [ ":usb" ]
+ visibility = [ ":usb" ]
}
« crypto/BUILD.gn ('K') | « crypto/BUILD.gn ('k') | net/BUILD.gn » ('j') | net/dns/host_resolver_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698