Issue 246303005: Make GN's "check" run cleanly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246303005: Make GN's "check" run cleanly. (Closed)

Created:
6 years, 8 months ago by brettw

Modified:
6 years, 8 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina, cbentzel+watch_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make GN's "check" run cleanly. This fixes a bunch of minor issues, mostly header file dependencies for undeclared dependencies. This also fixes some random TODOs. R=scottmg@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265382

Patch Set 1 #

Total comments: 3

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -12 lines)			Patch
M	crypto/BUILD.gn	View	2 chunks	+4 lines, -1 line	1 comment	Download
M	device/usb/BUILD.gn	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	net/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/dns/host_resolver_impl.h	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	net/third_party/nss/ssl/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/BUILD.gn	View	2 chunks	+9 lines, -2 lines	0 comments	Download
M	skia/skia_gn_files.gypi	View	2 chunks	+0 lines, -3 lines	1 comment	Download
M	tools/gn/secondary/testing/gtest/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

https://codereview.chromium.org/246303005/diff/1/crypto/BUILD.gn File crypto/BUILD.gn (left): https://codereview.chromium.org/246303005/diff/1/crypto/BUILD.gn#oldcode16 crypto/BUILD.gn:16: "crypto_module_blocking_password_delegate.h", This file doesn't exist. https://codereview.chromium.org/246303005/diff/1/net/dns/host_resolver_impl.h File net/dns/host_resolver_impl.h (left): ...

6 years, 8 months ago (2014-04-22 21:17:22 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r265382.

Expand Messages | Collapse Messages