Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: chrome/browser/chromeos/net/network_throttling_observer_unittest.cc

Issue 2463023002: Revert of Add network throttling as an enterprise policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reverted by hand Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/net/network_throttling_observer_unittest.cc
diff --git a/chrome/browser/chromeos/net/network_throttling_observer_unittest.cc b/chrome/browser/chromeos/net/network_throttling_observer_unittest.cc
deleted file mode 100644
index 7cbcfc27a562b55cf0aaea6d1521050bac060769..0000000000000000000000000000000000000000
--- a/chrome/browser/chromeos/net/network_throttling_observer_unittest.cc
+++ /dev/null
@@ -1,80 +0,0 @@
-// Copyright (c) 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include <memory>
-
-#include "base/message_loop/message_loop.h"
-#include "chrome/browser/chromeos/net/network_throttling_observer.h"
-#include "chrome/common/pref_names.h"
-#include "chromeos/dbus/dbus_thread_manager.h"
-#include "chromeos/dbus/mock_shill_manager_client.h"
-#include "chromeos/network/network_state_handler.h"
-#include "components/prefs/pref_registry_simple.h"
-#include "components/prefs/testing_pref_service.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using testing::_;
-using testing::Mock;
-using testing::NiceMock;
-
-namespace chromeos {
-
-namespace test {
-
-class NetworkThrottlingObserverTest : public ::testing::Test {
- public:
- NetworkThrottlingObserverTest() : message_loop_(new base::MessageLoop()) {
- DBusThreadManager::Initialize();
- std::unique_ptr<DBusThreadManagerSetter> dbus_setter =
- DBusThreadManager::GetSetterForTesting();
- mock_manager_client_ = new NiceMock<MockShillManagerClient>();
- dbus_setter->SetShillManagerClient(
- std::unique_ptr<ShillManagerClient>(mock_manager_client_));
- NetworkStateHandler::InitializeForTest();
- NetworkHandler::Initialize();
- local_state_ = new TestingPrefServiceSimple();
- local_state_->registry()->RegisterDictionaryPref(
- prefs::kNetworkThrottlingEnabled);
- observer_.reset(new NetworkThrottlingObserver(local_state_));
- }
-
- ~NetworkThrottlingObserverTest() override { delete mock_manager_client_; }
-
- std::unique_ptr<base::MessageLoop> message_loop_;
- std::unique_ptr<NetworkThrottlingObserver> observer_;
- TestingPrefServiceSimple* local_state_;
- MockShillManagerClient* mock_manager_client_;
-
- private:
- DISALLOW_COPY_AND_ASSIGN(NetworkThrottlingObserverTest);
-};
-
-TEST_F(NetworkThrottlingObserverTest, ThrottlingChangeCallsShill) {
- // Test that a change in the throttling policy value leads to
- // shill_manager_client being called.
- base::DictionaryValue updated_throttling_policy;
- bool enabled = true;
- uint32_t upload_rate = 1200;
- uint32_t download_rate = 2000;
- updated_throttling_policy.SetBoolean("enabled", enabled);
- updated_throttling_policy.SetInteger("upload_rate_kbits", upload_rate);
- updated_throttling_policy.SetInteger("download_rate_kbits", download_rate);
- EXPECT_CALL(
- *mock_manager_client_,
- SetNetworkThrottlingStatus(enabled, upload_rate, download_rate, _, _))
- .Times(1);
- local_state_->Set(prefs::kNetworkThrottlingEnabled,
- updated_throttling_policy);
- Mock::VerifyAndClearExpectations(mock_manager_client_);
-
- // Clearing the preference should disable throttling
- EXPECT_CALL(*mock_manager_client_,
- SetNetworkThrottlingStatus(false, 0, 0, _, _))
- .Times(1);
- local_state_->ClearPref(prefs::kNetworkThrottlingEnabled);
-}
-
-} // namespace test
-} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698