Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2463023002: Revert of Add network throttling as an enterprise policy (Closed)

Created:
4 years, 1 month ago by phoglund_chromium
Modified:
4 years, 1 month ago
CC:
sduraisamy, Kevin Cernekee, Sameer Nanda
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add network throttling as an enterprise policy (patchset #17 id:320001 of https://codereview.chromium.org/2364703002/ ) Reason for revert: Introduces memory leak; see discussion in https://bugs.chromium.org/p/chromium/issues/detail?id=660769. BUG=660769 Original issue's description: > Add support for an enterprise policy that lets the admin > turn on network throttling, and specify the upload and download rates in kbps to throttle to. > > BUG=642811 > TEST=(1) Unit-tests > (2) Added network throttling policy to YAPS server, > enabled throttling with various values, disabled, > and checked that changes propagate to client device. > > Signed-off-by: Kirtika Ruchandani <kirtika@google.com>; > Committed: https://crrev.com/7db3c2b899d448dc0235e03a248df83aa5778ebf > Cr-Commit-Position: refs/heads/master@{#428565} TBR=bartfab@chromium.org,stevenjb@chromium.org,kirtika@google.com,michaelpg@chromium.org,mnissler@chromium.org,atwilson@chromium.org,gab@chromium.org,brettw@chromium.org,isherman@chromium.org,asvitkine@chromium.org,thestig@chromium.org,kirtika@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=642811 Committed: https://crrev.com/02a8965352416f5c892f511b56bf4c37c778f507 Cr-Commit-Position: refs/heads/master@{#428703}

Patch Set 1 #

Patch Set 2 : Reverted by hand #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -416 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 3 chunks +0 lines, -4 lines 0 comments Download
D chrome/browser/chromeos/net/network_throttling_observer.h View 1 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/chromeos/net/network_throttling_observer.cc View 1 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/chromeos/net/network_throttling_observer_unittest.cc View 1 1 chunk +0 lines, -80 lines 0 comments Download
M chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/policy/proto/chrome_device_policy.proto View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 1 chunk +0 lines, -10 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chromeos/dbus/mock_shill_manager_client.h View 1 1 chunk +1 line, -6 lines 0 comments Download
M chromeos/dbus/shill_manager_client.h View 1 1 chunk +0 lines, -11 lines 0 comments Download
M chromeos/dbus/shill_manager_client.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download
M chromeos/dbus/shill_manager_client_unittest.cc View 1 2 chunks +0 lines, -39 lines 0 comments Download
M chromeos/network/network_state_handler.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chromeos/network/network_state_handler.cc View 1 2 chunks +0 lines, -13 lines 0 comments Download
M chromeos/network/shill_property_handler.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chromeos/network/shill_property_handler.cc View 1 1 chunk +0 lines, -12 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 2 chunks +1 line, -39 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
phoglund_chromium
Created Revert of Add network throttling as an enterprise policy
4 years, 1 month ago (2016-10-31 12:48:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463023002/1
4 years, 1 month ago (2016-10-31 12:48:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463023002/1
4 years, 1 month ago (2016-10-31 12:49:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/293036)
4 years, 1 month ago (2016-10-31 12:54:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463023002/1
4 years, 1 month ago (2016-10-31 12:56:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/293039)
4 years, 1 month ago (2016-10-31 13:02:03 UTC) #14
phoglund_chromium
On 2016/10/31 13:02:03, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 1 month ago (2016-10-31 13:15:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2463023002/70001
4 years, 1 month ago (2016-10-31 13:20:32 UTC) #17
phoglund_chromium
On 2016/10/31 13:15:51, phoglund_chrome wrote: > On 2016/10/31 13:02:03, commit-bot: I haz the power wrote: ...
4 years, 1 month ago (2016-10-31 13:21:49 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years, 1 month ago (2016-10-31 14:20:38 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 14:22:17 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02a8965352416f5c892f511b56bf4c37c778f507
Cr-Commit-Position: refs/heads/master@{#428703}

Powered by Google App Engine
This is Rietveld 408576698