Add a new telemetry benchmark to stress-test WebRTC.

Add a new telemetry benchmark to stress-test WebRTC.

BUG=651820
NOTRY=True
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Committed: https://crrev.com/1d38116383dc36f6be57077b86e3deaaae6cba20
Cr-Commit-Position: refs/heads/master@{#429244}

[ehmaldonado_chromium, 2016-10-31 16:20:08]

Description was changed from

==========
Add a new telemetry benchmark to stress-test WebRTC.

BUG=651820
==========

to

==========
Add a new telemetry benchmark to stress-test WebRTC.

BUG=651820
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[ehmaldonado_chromium, 2016-10-31 16:26:41]

Patchset #1 (id:1) has been deleted

[ehmaldonado_chromium, 2016-10-31 16:28:41]

Patchset #1 (id:20001) has been deleted

[ehmaldonado_chromium, 2016-10-31 16:29:18]

ehmaldonado@chromium.org changed reviewers:
+ phoglund@chromium.org

[ehmaldonado_chromium, 2016-10-31 16:29:19]

https://codereview.chromium.org/2463013003/diff/40001/tools/perf/page_sets/we...
File tools/perf/page_sets/webrtc_cases.py (right):

https://codereview.chromium.org/2463013003/diff/40001/tools/perf/page_sets/we...
tools/perf/page_sets/webrtc_cases.py:170:
'document.getElementById("peer-connections-input").value=15')
I couldn't figure out how to set the slider or the text input.

[phoglund_chromium, 2016-11-01 09:41:18]

lgtm

[ehmaldonado_chromium, 2016-11-01 10:13:28]

On 2016/11/01 09:41:18, phoglund_chrome wrote:
> lgtm

Who should I add who's an OWNER?

[phoglund_chromium, 2016-11-01 10:23:17]

phoglund@chromium.org changed reviewers:
+ sullivan@chromium.org

[phoglund_chromium, 2016-11-01 10:23:17]

Annie, would you mind owner-stamping? We're adding a new page set for
stress-testing, which is targeted towards recent WebRTC performance regressions.

[sullivan, 2016-11-01 12:39:23]

https://codereview.chromium.org/2463013003/diff/40001/tools/perf/page_sets/we...
File tools/perf/page_sets/webrtc_cases.py (right):

https://codereview.chromium.org/2463013003/diff/40001/tools/perf/page_sets/we...
tools/perf/page_sets/webrtc_cases.py:162: url= WEBRTC_TEST_PAGES_URL +
'multiple-peerconnections/',
Has this already been added to cloud storage?

https://codereview.chromium.org/2463013003/diff/40001/tools/perf/page_sets/we...
tools/perf/page_sets/webrtc_cases.py:170:
'document.getElementById("peer-connections-input").value=15')
On 2016/10/31 16:29:19, ehmaldonado_chromium wrote:
> I couldn't figure out how to set the slider or the text input.

Should there be a comment in the code explaining a bit more here? (I don't have
the context to know what the slider or text input are supposed to do)

[ehmaldonado_chromium, 2016-11-01 13:27:26]

PTAL

https://codereview.chromium.org/2463013003/diff/40001/tools/perf/page_sets/we...
File tools/perf/page_sets/webrtc_cases.py (right):

https://codereview.chromium.org/2463013003/diff/40001/tools/perf/page_sets/we...
tools/perf/page_sets/webrtc_cases.py:162: url= WEBRTC_TEST_PAGES_URL +
'multiple-peerconnections/',
On 2016/11/01 12:39:23, sullivan wrote:
> Has this already been added to cloud storage?

It has now.
Thanks :)

https://codereview.chromium.org/2463013003/diff/40001/tools/perf/page_sets/we...
tools/perf/page_sets/webrtc_cases.py:170:
'document.getElementById("peer-connections-input").value=15')
On 2016/11/01 12:39:23, sullivan wrote:
> On 2016/10/31 16:29:19, ehmaldonado_chromium wrote:
> > I couldn't figure out how to set the slider or the text input.
> 
> Should there be a comment in the code explaining a bit more here? (I don't
have
> the context to know what the slider or text input are supposed to do)

Done. This is supposed to set the number of peer connections to create in the
test page.

[sullivan, 2016-11-01 13:29:07]

lgtm

[ehmaldonado_chromium, 2016-11-01 13:29:28]

The CQ bit was checked by ehmaldonado@chromium.org

[ehmaldonado_chromium, 2016-11-01 13:29:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
phoglund@chromium.org
Link to the patchset: https://codereview.chromium.org/2463013003/#ps80001
(title: "Upload webrtc_stresstest_cases to cloud storage.")

[commit-bot: I haz the power, 2016-11-01 13:29:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 18:14:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 18:14:35]

Try jobs failed on following builders:
  android_s5_perf_cq on master.tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)

[ehmaldonado_chromium, 2016-11-01 18:16:24]

On 2016/11/01 18:14:35, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_s5_perf_cq on master.tryserver.chromium.perf (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)

Is this a real failure?

[phoglund_chromium, 2016-11-02 09:20:46]

On 2016/11/01 18:16:24, ehmaldonado_chromium wrote:
> On 2016/11/01 18:14:35, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   android_s5_perf_cq on master.tryserver.chromium.perf (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
> 
> Is this a real failure?

I don't think so. As you can see, it's just one android device failing, and it
fails before the test can even start (fails to "create the browser"), and it
fails on all page sets and not just your new one. Set NOTRY=True in the CL
description and add this explanation, then file a go/bugatrooper bug on that
trybot (or I think you can reply to the try failure email directly or something,
there's instructions there).

[ehmaldonado_chromium, 2016-11-02 09:26:28]

Description was changed from

==========
Add a new telemetry benchmark to stress-test WebRTC.

BUG=651820
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
Add a new telemetry benchmark to stress-test WebRTC.

BUG=651820
NOTRY=True
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[ehmaldonado_chromium, 2016-11-02 09:26:37]

The CQ bit was checked by ehmaldonado@chromium.org

[commit-bot: I haz the power, 2016-11-02 09:26:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 09:31:25]

Description was changed from

==========
Add a new telemetry benchmark to stress-test WebRTC.

BUG=651820
NOTRY=True
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
Add a new telemetry benchmark to stress-test WebRTC.

BUG=651820
NOTRY=True
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[commit-bot: I haz the power, 2016-11-02 09:31:26]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-11-02 09:33:16]

Description was changed from

==========
Add a new telemetry benchmark to stress-test WebRTC.

BUG=651820
NOTRY=True
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
Add a new telemetry benchmark to stress-test WebRTC.

BUG=651820
NOTRY=True
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Committed: https://crrev.com/1d38116383dc36f6be57077b86e3deaaae6cba20
Cr-Commit-Position: refs/heads/master@{#429244}
==========

[commit-bot: I haz the power, 2016-11-02 09:33:17]

Patchset 3 (id:??) landed as
https://crrev.com/1d38116383dc36f6be57077b86e3deaaae6cba20
Cr-Commit-Position: refs/heads/master@{#429244}