Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2463002: - Add a pointer to StubCache from Isolate.... (Closed)

Created:
10 years, 6 months ago by zarko
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

- Add a pointer to StubCache from Isolate. - Remove AllStatic parent from StubCache. - Add empty constructor to StubCache. Committed: http://code.google.com/p/v8/source/detail?r=4765

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M src/isolate.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M src/stub-cache.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/stub-cache.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
http://codereview.chromium.org/2463002/diff/6001/7001 File src/isolate.cc (right): http://codereview.chromium.org/2463002/diff/6001/7001#newcode73 src/isolate.cc:73: if (stubCache_ != NULL) { It's safe to delete ...
10 years, 6 months ago (2010-06-01 12:15:46 UTC) #1
zarko
10 years, 6 months ago (2010-06-01 12:25:43 UTC) #2
Vitaly Repeshko
10 years, 6 months ago (2010-06-01 13:12:15 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698