courgette/disassembler_win32_x64.cc - Issue 2462993003: [Courgette] Refactor: Add and use Instruction*Receptor classes; call ParseFile() in 2 passes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/disassembler_win32_x64.cc

Issue 2462993003: [Courgette] Refactor: Add and use Instruction*Receptor classes; call ParseFile() in 2 passes. (Closed)

Patch Set: Make AssemblyProgram::CreateInstruction*Receptor() return CheckBool. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: courgette/disassembler_win32_x64.cc

diff --git a/courgette/disassembler_win32_x64.cc b/courgette/disassembler_win32_x64.cc

index c000d1031841160cb0ae119e869310bfb5a58ce4..9b91d9ebbeb89dda143c365f65b9ee639883f75c 100644

--- a/courgette/disassembler_win32_x64.cc

+++ b/courgette/disassembler_win32_x64.cc

@@ -32,8 +32,8 @@ RVA DisassemblerWin32X64::Address64ToRVA(uint64_t address) const {

}

CheckBool DisassemblerWin32X64::EmitAbs(Label* label,

- AssemblyProgram* program) {

- return program->EmitAbs64(label);

+ InstructionReceptor* receptor) const {

+ return receptor->EmitAbs64(label);

}

void DisassemblerWin32X64::ParseRel32RelocsFromSection(const Section* section) {