Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: courgette/disassembler_win32_x86.cc

Issue 2462993003: [Courgette] Refactor: Add and use Instruction*Receptor classes; call ParseFile() in 2 passes. (Closed)
Patch Set: Fix comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « courgette/disassembler_win32_x86.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "courgette/disassembler_win32_x86.h" 5 #include "courgette/disassembler_win32_x86.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "courgette/assembly_program.h" 10 #include "courgette/assembly_program.h"
(...skipping 13 matching lines...) Expand all
24 return Address32ToRVA(Read32LittleEndian(p)); 24 return Address32ToRVA(Read32LittleEndian(p));
25 } 25 }
26 26
27 RVA DisassemblerWin32X86::Address32ToRVA(uint32_t address) const { 27 RVA DisassemblerWin32X86::Address32ToRVA(uint32_t address) const {
28 if (address < image_base() || address >= image_base() + size_of_image_) 28 if (address < image_base() || address >= image_base() + size_of_image_)
29 return kNoRVA; 29 return kNoRVA;
30 return static_cast<RVA>(address - image_base()); 30 return static_cast<RVA>(address - image_base());
31 } 31 }
32 32
33 CheckBool DisassemblerWin32X86::EmitAbs(Label* label, 33 CheckBool DisassemblerWin32X86::EmitAbs(Label* label,
34 AssemblyProgram* program) { 34 InstructionReceptor* receptor) const {
35 return program->EmitAbs32(label); 35 return receptor->EmitAbs32(label);
36 } 36 }
37 37
38 void DisassemblerWin32X86::ParseRel32RelocsFromSection(const Section* section) { 38 void DisassemblerWin32X86::ParseRel32RelocsFromSection(const Section* section) {
39 // TODO(sra): use characteristic. 39 // TODO(sra): use characteristic.
40 bool isCode = strcmp(section->name, ".text") == 0; 40 bool isCode = strcmp(section->name, ".text") == 0;
41 if (!isCode) 41 if (!isCode)
42 return; 42 return;
43 43
44 FileOffset start_file_offset = section->file_offset_of_raw_data; 44 FileOffset start_file_offset = section->file_offset_of_raw_data;
45 FileOffset end_file_offset = start_file_offset + section->size_of_raw_data; 45 FileOffset end_file_offset = start_file_offset + section->size_of_raw_data;
(...skipping 10 matching lines...) Expand all
56 finder.Find(start_pointer, end_pointer, start_rva, end_rva, abs32_locations_); 56 finder.Find(start_pointer, end_pointer, start_rva, end_rva, abs32_locations_);
57 finder.SwapRel32Locations(&rel32_locations_); 57 finder.SwapRel32Locations(&rel32_locations_);
58 58
59 #if COURGETTE_HISTOGRAM_TARGETS 59 #if COURGETTE_HISTOGRAM_TARGETS
60 DCHECK(rel32_target_rvas_.empty()); 60 DCHECK(rel32_target_rvas_.empty());
61 finder.SwapRel32TargetRVAs(&rel32_target_rvas_); 61 finder.SwapRel32TargetRVAs(&rel32_target_rvas_);
62 #endif 62 #endif
63 } 63 }
64 64
65 } // namespace courgette 65 } // namespace courgette
OLDNEW
« no previous file with comments | « courgette/disassembler_win32_x86.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698