Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: components/data_use_measurement/core/data_use_ascriber.h

Issue 2462983003: Move data use measurement to DataUseNetworkDelegate (Closed)
Patch Set: Addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_use_measurement/core/data_use_ascriber.h
diff --git a/components/data_use_measurement/core/data_use_ascriber.h b/components/data_use_measurement/core/data_use_ascriber.h
index 5abaeabc6317aeb243b77dedb5817d48918f827f..2596045ab8e1015b3a9ec82b775cb8e3aedc163a 100644
--- a/components/data_use_measurement/core/data_use_ascriber.h
+++ b/components/data_use_measurement/core/data_use_ascriber.h
@@ -9,6 +9,8 @@
#include <memory>
+#include "components/data_use_measurement/core/data_use_measurement.h"
+#include "components/metrics/data_use_tracker.h"
#include "url/gurl.h"
namespace net {
@@ -19,6 +21,7 @@ class URLRequest;
namespace data_use_measurement {
class DataUseRecorder;
+class URLRequestClassifier;
// Abstract class that manages instances of DataUseRecorder and maps
// a URLRequest instance to its appropriate DataUseRecorder. An embedder
@@ -31,7 +34,8 @@ class DataUseAscriber {
// Creates a network delegate that will be used to track data use.
std::unique_ptr<net::NetworkDelegate> CreateNetworkDelegate(
- std::unique_ptr<net::NetworkDelegate> wrapped_network_delegate);
+ std::unique_ptr<net::NetworkDelegate> wrapped_network_delegate,
+ const metrics::UpdateUsagePrefCallbackType& metrics_data_use_forwarder);
// Returns the DataUseRecorder to which data usage for the given URL should
// be ascribed. If no existing DataUseRecorder exists, a new one will be
@@ -50,6 +54,9 @@ class DataUseAscriber {
int64_t bytes_received);
virtual void OnUrlRequestCompleted(net::URLRequest* request, bool started);
+
+ virtual std::unique_ptr<URLRequestClassifier>
+ CreateURLRequestClassifier() = 0;
};
} // namespace data_use_measurement

Powered by Google App Engine
This is Rietveld 408576698