Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: components/data_use_measurement/core/data_use_network_delegate.cc

Issue 2462983003: Move data use measurement to DataUseNetworkDelegate (Closed)
Patch Set: Move DataUseMeasurement to core Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_use_measurement/core/data_use_network_delegate.cc
diff --git a/components/data_use_measurement/core/data_use_network_delegate.cc b/components/data_use_measurement/core/data_use_network_delegate.cc
index e7cb035ab08b61daec1763aecb1c38866393bb96..fe56d77bb6c92579ceb8b7ddf9507b40c5478829 100644
--- a/components/data_use_measurement/core/data_use_network_delegate.cc
+++ b/components/data_use_measurement/core/data_use_network_delegate.cc
@@ -13,9 +13,14 @@
namespace data_use_measurement {
DataUseNetworkDelegate::DataUseNetworkDelegate(
std::unique_ptr<NetworkDelegate> nested_network_delegate,
- DataUseAscriber* ascriber)
+ DataUseAscriber* ascriber,
+ const DataUseMeasurement::IsUserInitiatedRequestCallbackType&
+ is_user_initiated_request_callback,
+ const metrics::UpdateUsagePrefCallbackType& metrics_data_use_forwarder)
: net::LayeredNetworkDelegate(std::move(nested_network_delegate)),
- ascriber_(ascriber) {
+ ascriber_(ascriber),
+ data_use_measurement_(is_user_initiated_request_callback,
+ metrics_data_use_forwarder) {
DCHECK(ascriber);
}
@@ -26,29 +31,34 @@ void DataUseNetworkDelegate::OnBeforeURLRequestInternal(
const net::CompletionCallback& callback,
GURL* new_url) {
ascriber_->OnBeforeUrlRequest(request);
+ data_use_measurement_.OnBeforeURLRequest(request);
}
void DataUseNetworkDelegate::OnBeforeRedirectInternal(
net::URLRequest* request,
const GURL& new_location) {
ascriber_->OnBeforeRedirect(request, new_location);
+ data_use_measurement_.OnBeforeRedirect(*request, new_location);
}
void DataUseNetworkDelegate::OnNetworkBytesReceivedInternal(
net::URLRequest* request,
int64_t bytes_received) {
ascriber_->OnNetworkBytesReceived(request, bytes_received);
+ data_use_measurement_.OnNetworkBytesReceived(*request, bytes_received);
}
void DataUseNetworkDelegate::OnNetworkBytesSentInternal(
net::URLRequest* request,
int64_t bytes_sent) {
ascriber_->OnNetworkBytesSent(request, bytes_sent);
+ data_use_measurement_.OnNetworkBytesSent(*request, bytes_sent);
}
void DataUseNetworkDelegate::OnCompletedInternal(net::URLRequest* request,
bool started) {
ascriber_->OnUrlRequestCompleted(request, started);
+ data_use_measurement_.OnCompleted(*request, started);
}
} // namespace data_use_measurement

Powered by Google App Engine
This is Rietveld 408576698