Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: components/data_use_measurement/content/content_url_request_classifier.cc

Issue 2462983003: Move data use measurement to DataUseNetworkDelegate (Closed)
Patch Set: Rebased and fixed nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_use_measurement/content/content_url_request_classifier.cc
diff --git a/components/data_use_measurement/content/content_url_request_classifier.cc b/components/data_use_measurement/content/content_url_request_classifier.cc
new file mode 100644
index 0000000000000000000000000000000000000000..23bbd8baa9624a0515bfab3b4bf2026ab5e4243a
--- /dev/null
+++ b/components/data_use_measurement/content/content_url_request_classifier.cc
@@ -0,0 +1,29 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/data_use_measurement/content/content_url_request_classifier.h"
+
+#include "content/public/browser/resource_request_info.h"
+#include "net/url_request/url_request.h"
+
+namespace data_use_measurement {
+
+bool IsUserRequest(const net::URLRequest& request) {
+ // The presence of ResourecRequestInfo in |request| implies that this request
+ // was created for a content::WebContents. For now we could add a condition to
+ // check ProcessType in info is content::PROCESS_TYPE_RENDERER, but it won't
+ // be compatible with upcoming PlzNavigate architecture. So just existence of
+ // ResourceRequestInfo is verified, and the current check should be compatible
+ // with upcoming changes in PlzNavigate.
+ // TODO(rajendrant): Verify this condition for different use cases. See
+ // crbug.com/626063.
+ return content::ResourceRequestInfo::ForRequest(&request) != nullptr;
+}
+
+bool ContentURLRequestClassifier::IsUserRequest(
+ const net::URLRequest& request) const {
+ return data_use_measurement::IsUserRequest(request);
+}
+
+} // namespace data_use_measurement

Powered by Google App Engine
This is Rietveld 408576698