components/data_use_measurement/core/DEPS - Issue 2462983003: Move data use measurement to DataUseNetworkDelegate

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/data_use_measurement/core/DEPS

Issue 2462983003: Move data use measurement to DataUseNetworkDelegate (Closed)

Patch Set: Fixed linux unittest compile Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/data_use_measurement/core/BUILD.gn ('k') | components/data_use_measurement/core/data_use_ascriber.h » ('j') | components/data_use_measurement/core/data_use_network_delegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+net",	2 "+net",

	3 "+components/metrics",

	4 "+content/public/common",
	Not at Google. Contact bengr 2016/11/01 21:32:04 data_use_measurement/core/ should not depend on co data_use_measurement/core/ should not depend on content/. I agree with the general direction of this cl that DataUseMeasurement could use data_use_measurement/ rather than being hardcoded in ChromeNetworkDelegate. You have a number of options: 1) Allow observers on DataUseAscriber. Then DataUseMeasurement could just be an obsever of DataUseAscriber. This functionality will be required for other purposes such as Page Size Pingback. You could postpone this cl until the observer functionality is in, or add it yourself. 2) It seems the only reason DataUseMeasurement class is in content is because of dependency on ResourceRequestInfo for IsUserInitiatedRequest(). DataUseMeasurement could be given a callback that given a URLRequest can tell whether it is user initiated. The callback interface would be defined in core/ and the implementation under /content. Raj 2016/11/08 22:39:31 I am following option#2. option#1 will not be eno Show quoted text On 2016/11/01 21:32:04, kundaji wrote: > data_use_measurement/core/ should not depend on content/. > > I agree with the general direction of this cl that DataUseMeasurement could use > data_use_measurement/ rather than being hardcoded in ChromeNetworkDelegate. > > You have a number of options: > 1) Allow observers on DataUseAscriber. Then DataUseMeasurement could just be an > obsever of DataUseAscriber. This functionality will be required for other > purposes such as Page Size Pingback. You could postpone this cl until the > observer functionality is in, or add it yourself. > > 2) It seems the only reason DataUseMeasurement class is in content is because of > dependency on ResourceRequestInfo for IsUserInitiatedRequest(). > DataUseMeasurement could be given a callback that given a URLRequest can tell > whether it is user initiated. The callback interface would be defined in core/ > and the implementation under /content. I am following option#2. option#1 will not be enough for my usecase to get datause of various combinations such as chrome app in background/foreground, chrome tab in background/foreground, screen on/off, etc. Part of this info is obtained from web content observers and remaining from other places. So DataUseMeasurement needs to fuse all these info together. Observers on DataUseAscriber would be as simple as returning datause for a tab/webcontent, and do not consider these various combinations.
	5 "+content/public/browser",

3 ]	6 ]

OLD	NEW