Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2462973003: [ic] Experiment: disable map-specific handler cache. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Experiment: disable map-specific handler cache. IC data handlers support most of the hot cases nowdays. Let's see if the map-specific code cache still help us to improve things. BUG=v8:5561 Committed: https://crrev.com/a52ffd44fdc7983dda7a0ca7ad2016853d80cbe1 Cr-Commit-Position: refs/heads/master@{#40685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/ic/handler-compiler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-code-cache.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-10-31 16:55:51 UTC) #4
Jakob Kummerow
LGTM, good luck! :-)
4 years, 1 month ago (2016-10-31 17:14:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462973003/1
4 years, 1 month ago (2016-11-01 11:16:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 11:18:27 UTC) #10
Jakob Kummerow
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2474653002/ by jkummerow@chromium.org. ...
4 years, 1 month ago (2016-11-02 13:23:17 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a52ffd44fdc7983dda7a0ca7ad2016853d80cbe1
Cr-Commit-Position: refs/heads/master@{#40685}

Powered by Google App Engine
This is Rietveld 408576698