Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2462973002: Delete dead string IDS_AUTOFILL_WARNING_FORM_DISABLED (Closed)

Created:
4 years, 1 month ago by estark
Modified:
4 years, 1 month ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete dead string IDS_AUTOFILL_WARNING_FORM_DISABLED BUG= Committed: https://crrev.com/3eb3b4aff2b6fa5be5c69f4a7759d63e506effbf Cr-Commit-Position: refs/heads/master@{#428716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M components/autofill_strings.grdp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
estark
estade, PTAL? Was browsing some autofill code and noticed that this string is unused.
4 years, 1 month ago (2016-10-31 05:18:56 UTC) #6
Evan Stade
lgtm On Oct 30, 2016 11:18 PM, <estark@chromium.org> wrote: > Reviewers: Evan Stade > CL: ...
4 years, 1 month ago (2016-10-31 14:23:05 UTC) #7
Evan Stade
lgtm
4 years, 1 month ago (2016-10-31 14:26:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462973002/1
4 years, 1 month ago (2016-10-31 15:29:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 15:34:29 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3eb3b4aff2b6fa5be5c69f4a7759d63e506effbf Cr-Commit-Position: refs/heads/master@{#428716}
4 years, 1 month ago (2016-10-31 15:44:48 UTC) #13
xidachen
4 years, 1 month ago (2016-10-31 19:17:05 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2465923004/ by xidachen@chromium.org.

The reason for reverting is: Suspect causing failure here:
https://build.chromium.org/p/chromium.mac/builders/ios-simulator/builds/6991

Will reland if it is not the cause..

Powered by Google App Engine
This is Rietveld 408576698