Make gn_all depend on frame_analyzer.

Make gn_all depend on frame_analyzer.

After https://codereview.chromium.org/2409303003/ it seems
webrtc/tools/BUILD.gn is no longer processed so it's not possible
to build the frame_analyzer target as we used to do for our
custom WebRTC testers that runs video quality tests.

BUG=660937
TBR=dpranke@chromium.org

Committed: https://crrev.com/b1ab7b84734e30b086053e8791f19f4af18b781d
Cr-Commit-Position: refs/heads/master@{#428962}

[kjellander_chromium, 2016-10-31 21:24:26]

Description was changed from

==========
Make browser_tests depend on frame_analyzer.

After https://codereview.chromium.org/2409303003/ it seems
webrtc/tools/BUILD.gn is no longer processed so it's not possible
to build the frame_analyzer target as we used to do for our
custom WebRTC testers that runs video quality tests.

BUG=
==========

to

==========
Make browser_tests depend on frame_analyzer.

After https://codereview.chromium.org/2409303003/ it seems
webrtc/tools/BUILD.gn is no longer processed so it's not possible
to build the frame_analyzer target as we used to do for our
custom WebRTC testers that runs video quality tests.

BUG=660937
==========

[kjellander_chromium, 2016-10-31 21:24:26]

kjellander@chromium.org changed reviewers:
+ dpranke@chromium.org

[kjellander_chromium, 2016-10-31 21:25:08]

Depending on it always will introduce a few more objects being built
but I'm not sure what better way there is? I assume the net sum of objects built
is still lower since I remove those dependencies recently.

[kjellander_chromium, 2016-10-31 21:25:13]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 21:25:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-10-31 21:39:12]

I'm not sure I understand what you're trying to do.

Does browser_tests actually depend on frame_analyzer? AFAIK, it doesn't.

Or is it that you need *something* to depend on something in //webrtc/tools so
that the frame_analyzer target is defined?

If the latter, just add it to the top level //:gn_all target. If you only want
it to be pulled in a chromium+tip-of-tree-webrtc build, you can nest that behind
some sort of a build arg, but that's probably more complexity than is necessary.

[commit-bot: I haz the power, 2016-10-31 22:39:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 22:39:13]

Dry run: This issue passed the CQ dry run.

[kjellander_chromium, 2016-11-01 07:08:04]

On 2016/10/31 21:39:12, Dirk Pranke wrote:
> I'm not sure I understand what you're trying to do.
> 
> Does browser_tests actually depend on frame_analyzer? AFAIK, it doesn't.

Right, it doesn't. What you suggested below is the right solution to this.

> Or is it that you need *something* to depend on something in //webrtc/tools so
> that the frame_analyzer target is defined?

Exactly.

> If the latter, just add it to the top level //:gn_all target. If you only want
> it to be pulled in a chromium+tip-of-tree-webrtc build, you can nest that
behind
> some sort of a build arg, but that's probably more complexity than is
necessary.

Thanks. I only need it for desktop platforms so I added into a suitable
condition.

[kjellander_chromium, 2016-11-01 07:09:20]

kjellander@chromium.org changed reviewers:
+ jochen@chromium.org

[kjellander_chromium, 2016-11-01 07:09:21]

+jochen@chromium.org for EMEA owner approval

[kjellander_chromium, 2016-11-01 07:49:18]

Description was changed from

==========
Make browser_tests depend on frame_analyzer.

After https://codereview.chromium.org/2409303003/ it seems
webrtc/tools/BUILD.gn is no longer processed so it's not possible
to build the frame_analyzer target as we used to do for our
custom WebRTC testers that runs video quality tests.

BUG=660937
==========

to

==========
Make gn_all depend on frame_analyzer.

After https://codereview.chromium.org/2409303003/ it seems
webrtc/tools/BUILD.gn is no longer processed so it's not possible
to build the frame_analyzer target as we used to do for our
custom WebRTC testers that runs video quality tests.

BUG=660937
==========

[kjellander_chromium, 2016-11-01 07:49:55]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 07:50:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kjellander_chromium, 2016-11-01 07:52:28]

Description was changed from

==========
Make gn_all depend on frame_analyzer.

After https://codereview.chromium.org/2409303003/ it seems
webrtc/tools/BUILD.gn is no longer processed so it's not possible
to build the frame_analyzer target as we used to do for our
custom WebRTC testers that runs video quality tests.

BUG=660937
==========

to

==========
Make gn_all depend on frame_analyzer.

After https://codereview.chromium.org/2409303003/ it seems
webrtc/tools/BUILD.gn is no longer processed so it's not possible
to build the frame_analyzer target as we used to do for our
custom WebRTC testers that runs video quality tests.

BUG=660937
TBR=dpranke@chromium.org
==========

[kjellander_chromium, 2016-11-01 07:55:28]

TBRing Dirk to unbreak the bots in https://build.chromium.org/p/chromium.webrtc
since Jochen is OOO today (seems to be the only EMEA owner in src/build/OWNERS).

[kjellander_chromium, 2016-11-01 07:55:33]

The CQ bit was unchecked by kjellander@chromium.org

[kjellander_chromium, 2016-11-01 07:55:39]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2016-11-01 07:55:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 08:34:44]

Description was changed from

==========
Make gn_all depend on frame_analyzer.

After https://codereview.chromium.org/2409303003/ it seems
webrtc/tools/BUILD.gn is no longer processed so it's not possible
to build the frame_analyzer target as we used to do for our
custom WebRTC testers that runs video quality tests.

BUG=660937
TBR=dpranke@chromium.org
==========

to

==========
Make gn_all depend on frame_analyzer.

After https://codereview.chromium.org/2409303003/ it seems
webrtc/tools/BUILD.gn is no longer processed so it's not possible
to build the frame_analyzer target as we used to do for our
custom WebRTC testers that runs video quality tests.

BUG=660937
TBR=dpranke@chromium.org
==========

[commit-bot: I haz the power, 2016-11-01 08:34:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-01 08:36:42]

Description was changed from

==========
Make gn_all depend on frame_analyzer.

After https://codereview.chromium.org/2409303003/ it seems
webrtc/tools/BUILD.gn is no longer processed so it's not possible
to build the frame_analyzer target as we used to do for our
custom WebRTC testers that runs video quality tests.

BUG=660937
TBR=dpranke@chromium.org
==========

to

==========
Make gn_all depend on frame_analyzer.

After https://codereview.chromium.org/2409303003/ it seems
webrtc/tools/BUILD.gn is no longer processed so it's not possible
to build the frame_analyzer target as we used to do for our
custom WebRTC testers that runs video quality tests.

BUG=660937
TBR=dpranke@chromium.org

Committed: https://crrev.com/b1ab7b84734e30b086053e8791f19f4af18b781d
Cr-Commit-Position: refs/heads/master@{#428962}
==========

[commit-bot: I haz the power, 2016-11-01 08:36:43]

Patchset 2 (id:??) landed as
https://crrev.com/b1ab7b84734e30b086053e8791f19f4af18b781d
Cr-Commit-Position: refs/heads/master@{#428962}

[Dirk Pranke, 2016-11-01 16:23:33]

lgtm