Mount MTP devices in Chrome OS Files.app.

chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/fileapi/file_system_backend.h"
 
 #include <set>
 
 #include "base/files/file_path.h"
 #include "base/path_service.h"
@@ skipping 23 matching lines @@
 TEST(ChromeOSFileSystemBackendTest, DefaultMountPoints) {
   // Make sure no system-level mount points are registered before testing
   // to avoid flakiness.
   fileapi::ExternalMountPoints::GetSystemInstance()->RevokeAllFileSystems();
 
   scoped_refptr<quota::SpecialStoragePolicy> storage_policy =
       new quota::MockSpecialStoragePolicy();
   scoped_refptr<fileapi::ExternalMountPoints> mount_points(
       fileapi::ExternalMountPoints::CreateRefCounted());
   chromeos::FileSystemBackend backend(
+      base::FilePath(),  // profile_path,
+      NULL,  // media_task_runner,

[mtomasz, 2014/04/23 12:17:19]

There seem to be no media_task_runner argument in the FileSystemBackend.

[kinaba, 2014/04/24 01:33:30]

Oops. Done.

       NULL,  // drive_delegate
       NULL,  // file_system_provider_delegate
       storage_policy,
       mount_points.get(),
       fileapi::ExternalMountPoints::GetSystemInstance());
   backend.AddSystemMountPoints();
   std::vector<base::FilePath> root_dirs = backend.GetRootDirectories();
   std::set<base::FilePath> root_dirs_set(root_dirs.begin(), root_dirs.end());
 
   // By default there should be 3 mount points (in system mount points):
   EXPECT_EQ(3u, root_dirs.size());
 
   EXPECT_TRUE(root_dirs_set.count(
       chromeos::CrosDisksClient::GetRemovableDiskMountPoint()));
   EXPECT_TRUE(root_dirs_set.count(
       chromeos::CrosDisksClient::GetArchiveMountPoint()));
   EXPECT_TRUE(root_dirs_set.count(base::FilePath(FPL("/usr/share/oem"))));
 }
 
 TEST(ChromeOSFileSystemBackendTest, GetRootDirectories) {
   scoped_refptr<quota::SpecialStoragePolicy> storage_policy =
       new quota::MockSpecialStoragePolicy();
   scoped_refptr<fileapi::ExternalMountPoints> mount_points(
       fileapi::ExternalMountPoints::CreateRefCounted());
 
   scoped_refptr<fileapi::ExternalMountPoints> system_mount_points(
       fileapi::ExternalMountPoints::CreateRefCounted());
 
-  chromeos::FileSystemBackend backend(NULL,  // drive_delegate
+  chromeos::FileSystemBackend backend(base::FilePath(),  // profile_path
+                                      NULL,  // media_task_runner,
+                                      NULL,  // drive_delegate
                                       NULL,  // file_system_provider_delegate
                                       storage_policy,
                                       mount_points.get(),
                                       system_mount_points.get());
 
   const size_t initial_root_dirs_size = backend.GetRootDirectories().size();
 
   // Register 'local' test mount points.
   mount_points->RegisterFileSystem("c",
                                    fileapi::kFileSystemTypeNativeLocal,
@@ skipping 25 matching lines @@
 
 TEST(ChromeOSFileSystemBackendTest, AccessPermissions) {
   url_util::AddStandardScheme("chrome-extension");
 
   scoped_refptr<quota::MockSpecialStoragePolicy> storage_policy =
       new quota::MockSpecialStoragePolicy();
   scoped_refptr<fileapi::ExternalMountPoints> mount_points(
       fileapi::ExternalMountPoints::CreateRefCounted());
   scoped_refptr<fileapi::ExternalMountPoints> system_mount_points(
       fileapi::ExternalMountPoints::CreateRefCounted());
-  chromeos::FileSystemBackend backend(NULL,  // drive_delegate
+  chromeos::FileSystemBackend backend(base::FilePath(),
+                                      NULL,
+                                      NULL,  // drive_delegate
                                       NULL,  // file_system_provider_delegate
                                       storage_policy,
                                       mount_points.get(),
                                       system_mount_points.get());
 
   std::string extension("ddammdhioacbehjngdmkjcjbnfginlla");
 
   storage_policy->AddFileHandler(extension);
 
   // Initialize mount points.
@@ skipping 72 matching lines @@
       CreateFileSystemURL(extension, "removable/foo", mount_points.get())));
 }
 
 TEST(ChromeOSFileSystemBackendTest, GetVirtualPathConflictWithSystemPoints) {
   scoped_refptr<quota::MockSpecialStoragePolicy> storage_policy =
       new quota::MockSpecialStoragePolicy();
   scoped_refptr<fileapi::ExternalMountPoints> mount_points(
       fileapi::ExternalMountPoints::CreateRefCounted());
   scoped_refptr<fileapi::ExternalMountPoints> system_mount_points(
       fileapi::ExternalMountPoints::CreateRefCounted());
-  chromeos::FileSystemBackend backend(NULL,  // drive_delegate
+  chromeos::FileSystemBackend backend(base::FilePath(),
+                                      NULL,
+                                      NULL,  // drive_delegate

[mtomasz, 2014/04/23 12:17:19]

optional: This is just an idea, but how about making a delegate for mtp
returning async utils and the stream reader/writer as it is done for drive and
file system provider? We wouldn't need to pass the profile path.

[kinaba, 2014/04/24 01:33:30]

Done.

                                       NULL,  // file_system_provider_delegate
                                       storage_policy,
                                       mount_points.get(),
                                       system_mount_points.get());
 
   const fileapi::FileSystemType type = fileapi::kFileSystemTypeNativeLocal;
   const fileapi::FileSystemMountOption option =
       fileapi::FileSystemMountOption();
 
   // Backend specific mount points.
@@ skipping 45 matching lines @@
     if (!kTestCases[i].success)
       continue;
 
     base::FilePath expected_virtual_path(kTestCases[i].virtual_path);
     EXPECT_EQ(expected_virtual_path, virtual_path)
         << "Resolving " << kTestCases[i].local_path;
   }
 }
 
 }  // namespace