Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: runtime/vm/assembler_arm64.cc

Issue 246293010: Enables first codegen test on arm64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm64.h ('k') | runtime/vm/assembler_x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm64.cc
===================================================================
--- runtime/vm/assembler_arm64.cc (revision 35315)
+++ runtime/vm/assembler_arm64.cc (working copy)
@@ -417,12 +417,12 @@
} else {
// TODO(zra): Since this sequence only needs to be decodable, it can be
// of variable length.
- LoadPatchableImmediate(reg, imm);
+ LoadImmediateFixed(reg, imm);
}
}
-void Assembler::LoadPatchableImmediate(Register reg, int64_t imm) {
+void Assembler::LoadImmediateFixed(Register reg, int64_t imm) {
const uint32_t w0 = Utils::Low32Bits(imm);
const uint32_t w1 = Utils::High32Bits(imm);
const uint16_t h0 = Utils::Low16Bits(w0);
@@ -451,6 +451,12 @@
orri(reg, reg, val_smi_tag);
}
} else {
+ // 0. Is it 0?
+ if (imm == 0) {
+ movz(reg, 0, 0);
+ return;
+ }
+
// 1. Can we use one orri operation?
Operand op;
Operand::OperandType ot;
@@ -719,6 +725,54 @@
}
+void Assembler::EnterDartFrameWithInfo(intptr_t frame_size, Register new_pp) {
+ // Setup the frame.
+ adr(TMP, 0); // TMP gets PC of this instruction.
+ EnterFrame(0);
+ Push(TMP); // Save PC Marker.
+ PushPP(); // Save PP.
+
+ // Load the pool pointer.
+ if (new_pp == kNoRegister) {
+ LoadPoolPointer(PP);
+ } else {
+ mov(PP, new_pp);
+ }
+
+ // Reserve space.
+ if (frame_size > 0) {
+ sub(SP, SP, Operand(frame_size));
+ }
+}
+
+
+// On entry to a function compiled for OSR, the caller's frame pointer, the
+// stack locals, and any copied parameters are already in place. The frame
+// pointer is already set up. The PC marker is not correct for the
+// optimized function and there may be extra space for spill slots to
+// allocate. We must also set up the pool pointer for the function.
+void Assembler::EnterOsrFrame(intptr_t extra_size, Register new_pp) {
+ const intptr_t offset = CodeSize();
+
+ Comment("EnterOsrFrame");
+ adr(TMP, 0);
+
+ AddImmediate(TMP, TMP, -offset, kNoRegister);
+ StoreToOffset(TMP, FP, kPcMarkerSlotFromFp * kWordSize);
+
+ // Setup pool pointer for this dart function.
+ if (new_pp == kNoRegister) {
+ LoadPoolPointer(PP);
+ } else {
+ mov(PP, new_pp);
+ }
+
+ if (extra_size > 0) {
+ sub(SP, SP, Operand(extra_size));
+ }
+}
+
+
void Assembler::LeaveDartFrame() {
// Restore and untag PP.
LoadFromOffset(PP, FP, kSavedCallerPpSlotFromFp * kWordSize);
« no previous file with comments | « runtime/vm/assembler_arm64.h ('k') | runtime/vm/assembler_x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698