Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/assembler_x64.cc

Issue 246293010: Enables first codegen test on arm64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/assembler_arm64.h ('K') | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/code_generator_test.cc » ('j') | runtime/vm/flow_graph_compiler_arm64.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_x64.cc
===================================================================
--- runtime/vm/assembler_x64.cc (revision 35264)
+++ runtime/vm/assembler_x64.cc (working copy)
@@ -2901,7 +2901,7 @@
void Assembler::EnterDartFrameWithInfo(intptr_t frame_size,
Register new_pp, Register new_pc) {
regis 2014/04/22 23:38:10 new_pc is not a good name. It is more like a pc_ma
zra 2014/04/23 17:18:45 Done.
if (new_pc == kNoRegister) {
- EnterDartFrame(0);
+ EnterDartFrame(frame_size);
regis 2014/04/22 23:38:10 bug?
zra 2014/04/23 17:18:45 I assume so, but I think we must have never passed
} else {
EnterFrame(0);
pushq(new_pc);
« runtime/vm/assembler_arm64.h ('K') | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/code_generator_test.cc » ('j') | runtime/vm/flow_graph_compiler_arm64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698