Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2462903002: sync compositor: Fix multiprocess software clipping (Closed)

Created:
4 years, 1 month ago by boliu
Modified:
4 years, 1 month ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sync compositor: Fix multiprocess software clipping Apply the clip before the matrix, so that matrix is not applied to it. Not entirely sure why recent clipping changes did not expose this. BUG=660119 Committed: https://crrev.com/3a3725735f8f32c95b672537726037b9d0b9cf10 Cr-Commit-Position: refs/heads/master@{#428700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/android/synchronous_compositor_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
boliu
for monday too, I guess
4 years, 1 month ago (2016-10-30 23:31:26 UTC) #2
Tobias Sargeant
On 2016/10/30 23:31:26, boliu wrote: > for monday too, I guess LGTM. (I wonder if ...
4 years, 1 month ago (2016-10-31 10:26:51 UTC) #7
boliu
On 2016/10/31 10:26:51, Tobias Sargeant wrote: > On 2016/10/30 23:31:26, boliu wrote: > > for ...
4 years, 1 month ago (2016-10-31 13:47:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462903002/1
4 years, 1 month ago (2016-10-31 13:47:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 13:51:46 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 13:54:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a3725735f8f32c95b672537726037b9d0b9cf10
Cr-Commit-Position: refs/heads/master@{#428700}

Powered by Google App Engine
This is Rietveld 408576698