Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2462843002: Update ash to use new devtools base agent (Closed)

Created:
4 years, 1 month ago by Sarmad Hashmi
Modified:
4 years, 1 month ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, kalyank, sadrul, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ash to use new devtools base agent This CL updates the ash dom_agent to use the newly added devtools_base_agent. Gets rid of the method AddDOMBackend because AddAgent replaces it (and all methods like it that would have been created). BUG=648701 Committed: https://crrev.com/08ed4b15d4f17c56b86620344d7a5f1544d2fa4d Cr-Commit-Position: refs/heads/master@{#428732}

Patch Set 1 #

Patch Set 2 : Update ash to use new devtools base agent #

Patch Set 3 : Update ash to use new devtools base agent #

Patch Set 4 : Update ash to use new devtools base agent #

Total comments: 2

Patch Set 5 : Rename devtools_dom_agent.* to ash_devtools_dom_agent.* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -167 lines) Patch
M ash/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/common/devtools/ash_devtools_dom_agent.h View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
A + ash/common/devtools/ash_devtools_dom_agent.cc View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M ash/common/devtools/devtools_dom_agent.h View 1 2 3 4 1 chunk +0 lines, -37 lines 0 comments Download
M ash/common/devtools/devtools_dom_agent.cc View 1 2 3 4 1 chunk +0 lines, -110 lines 0 comments Download
M ash/common/wm_shell.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M components/ui_devtools/devtools_client.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/ui_devtools/devtools_client.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (13 generated)
Sarmad Hashmi
PTAL sadrul@
4 years, 1 month ago (2016-10-29 16:30:47 UTC) #2
sadrul
lgtm
4 years, 1 month ago (2016-10-29 17:09:47 UTC) #3
Sarmad Hashmi
+sky@ for OWNERS review
4 years, 1 month ago (2016-10-29 21:52:26 UTC) #9
sky
LGTM https://codereview.chromium.org/2462843002/diff/60001/ash/common/devtools/devtools_dom_agent.h File ash/common/devtools/devtools_dom_agent.h (right): https://codereview.chromium.org/2462843002/diff/60001/ash/common/devtools/devtools_dom_agent.h#newcode5 ash/common/devtools/devtools_dom_agent.h:5: #ifndef ASH_COMMON_DEVTOOLS_DEVTOOLS_DOM_AGENT_H_ File name should match class name, ...
4 years, 1 month ago (2016-10-31 15:17:12 UTC) #10
Sarmad Hashmi
https://codereview.chromium.org/2462843002/diff/60001/ash/common/devtools/devtools_dom_agent.h File ash/common/devtools/devtools_dom_agent.h (right): https://codereview.chromium.org/2462843002/diff/60001/ash/common/devtools/devtools_dom_agent.h#newcode5 ash/common/devtools/devtools_dom_agent.h:5: #ifndef ASH_COMMON_DEVTOOLS_DEVTOOLS_DOM_AGENT_H_ On 2016/10/31 15:17:12, sky wrote: > File ...
4 years, 1 month ago (2016-10-31 16:19:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462843002/80001
4 years, 1 month ago (2016-10-31 16:19:41 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-10-31 16:24:17 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 16:45:47 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/08ed4b15d4f17c56b86620344d7a5f1544d2fa4d
Cr-Commit-Position: refs/heads/master@{#428732}

Powered by Google App Engine
This is Rietveld 408576698