Refactor audio API tests

Refactor audio API tests

Instead of using custom messages to send test reuslts from test
app to test runner for tests for API events, use standard
extensions::ResultCatcher to get results - it workss better with
chrome.test.assert methods and produces better failure messages.

Use chrome.test.listenOnce to register event listeners in tests.
Note that there is no need for chrome.test.succeed for test cases
using listenOnce - it will get called once listener is run (unless
listener function asserts, in which case test will fail).

Refactors audio/test.js - added helper methods for testing
relevant properties of devices returned by chrome.audio.getInfo to
make expectations a bit easier to specify/understand.
The refactored test are less dependent on exact order in which
audio devices are reported in device list (as the order is of no
relevance).

Committed: https://crrev.com/65dca4379e4a31128c1328c6d5e6b83840b4f9da
Cr-Commit-Position: refs/heads/master@{#429678}

[tbarzic, 2016-10-31 17:54:29]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 17:55:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 18:26:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 18:26:48]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tbarzic, 2016-10-31 18:35:50]

Description was changed from

==========
Cleanup audio API tests

Use standard extensions::ResultCatcher to wait for test results so
it plays better with chrome.test.assert methods (instead of seding
custom messages) - this produces better failure messages, and
assertions are cleaner.
Use chrome.test.listenOnce to register event listeners in tests.
Note that there is no need for chrome.test.succeed for test cases
using listenOnce - it will get called once listener is run (unless
listener function asserts).

Refactors audio/test.js - added helper methods for testing
relevant properties of devices returned by chrome.audio.getInfo.
The refactored test are less dependent on exact order in which
audio devices are reported in device list (as the order is of no
relevance).
==========

to

==========
Refactor audio API tests

Use standard extensions::ResultCatcher to wait for test results so
it plays better with chrome.test.assert methods (instead of seding
custom messages) - this produces better failure messages, and
assertions are cleaner.
Use chrome.test.listenOnce to register event listeners in tests.
Note that there is no need for chrome.test.succeed for test cases
using listenOnce - it will get called once listener is run (unless
listener function asserts).

Refactors audio/test.js - added helper methods for testing
relevant properties of devices returned by chrome.audio.getInfo.
The refactored test are less dependent on exact order in which
audio devices are reported in device list (as the order is of no
relevance).
==========

[tbarzic, 2016-10-31 18:52:49]

Description was changed from

==========
Refactor audio API tests

Use standard extensions::ResultCatcher to wait for test results so
it plays better with chrome.test.assert methods (instead of seding
custom messages) - this produces better failure messages, and
assertions are cleaner.
Use chrome.test.listenOnce to register event listeners in tests.
Note that there is no need for chrome.test.succeed for test cases
using listenOnce - it will get called once listener is run (unless
listener function asserts).

Refactors audio/test.js - added helper methods for testing
relevant properties of devices returned by chrome.audio.getInfo.
The refactored test are less dependent on exact order in which
audio devices are reported in device list (as the order is of no
relevance).
==========

to

==========
Refactor audio API tests

Instead of using custom messages to send test reuslts from test
app to test runner for tests for API events, use standard
extensions::ResultCatcher to get results - it workss better with
chrome.test.assert methods and produces better failure messages.

Use chrome.test.listenOnce to register event listeners in tests.
Note that there is no need for chrome.test.succeed for test cases
using listenOnce - it will get called once listener is run (unless
listener function asserts, in which case test will fail).

Refactors audio/test.js - added helper methods for testing
relevant properties of devices returned by chrome.audio.getInfo to
make expectations a bit easier to specify/understand.
The refactored test are less dependent on exact order in which
audio devices are reported in device list (as the order is of no
relevance).
==========

[tbarzic, 2016-10-31 18:53:20]

The CQ bit was checked by tbarzic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 18:53:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbarzic, 2016-10-31 19:01:02]

tbarzic@chromium.org changed reviewers:
+ steel@chromium.org

[commit-bot: I haz the power, 2016-10-31 19:33:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 19:33:13]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Rahul Chaturvedi, 2016-10-31 20:30:09]

steel@chromium.org changed reviewers:
+ jennyz@chromium.org

[Rahul Chaturvedi, 2016-10-31 20:30:10]

lgtm! Thanks for fixing these up.

(Adding Jenny, 'cause Audio)

https://codereview.chromium.org/2462833002/diff/80001/extensions/test/data/ap...
File extensions/test/data/api_test/audio/remove_nodes/background.js (right):

https://codereview.chromium.org/2462833002/diff/80001/extensions/test/data/ap...
extensions/test/data/api_test/audio/remove_nodes/background.js:40:
chrome.test.sendMessage("loaded");
nit: fix the " here too?

[tbarzic, 2016-10-31 20:37:11]

https://codereview.chromium.org/2462833002/diff/80001/extensions/test/data/ap...
File extensions/test/data/api_test/audio/remove_nodes/background.js (right):

https://codereview.chromium.org/2462833002/diff/80001/extensions/test/data/ap...
extensions/test/data/api_test/audio/remove_nodes/background.js:40:
chrome.test.sendMessage("loaded");
On 2016/10/31 20:30:10, Rahul Chaturvedi wrote:
> nit: fix the " here too?

Done.

[jennyz, 2016-11-02 23:45:09]

lgtm

[tbarzic, 2016-11-03 16:59:31]

The CQ bit was checked by tbarzic@chromium.org

[tbarzic, 2016-11-03 16:59:32]

The patchset sent to the CQ was uploaded after l-g-t-m from steel@chromium.org
Link to the patchset: https://codereview.chromium.org/2462833002/#ps100001
(title: "Refactor audio API tests")

[commit-bot: I haz the power, 2016-11-03 17:00:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 20:00:07]

Description was changed from

==========
Refactor audio API tests

Instead of using custom messages to send test reuslts from test
app to test runner for tests for API events, use standard
extensions::ResultCatcher to get results - it workss better with
chrome.test.assert methods and produces better failure messages.

Use chrome.test.listenOnce to register event listeners in tests.
Note that there is no need for chrome.test.succeed for test cases
using listenOnce - it will get called once listener is run (unless
listener function asserts, in which case test will fail).

Refactors audio/test.js - added helper methods for testing
relevant properties of devices returned by chrome.audio.getInfo to
make expectations a bit easier to specify/understand.
The refactored test are less dependent on exact order in which
audio devices are reported in device list (as the order is of no
relevance).
==========

to

==========
Refactor audio API tests

Instead of using custom messages to send test reuslts from test
app to test runner for tests for API events, use standard
extensions::ResultCatcher to get results - it workss better with
chrome.test.assert methods and produces better failure messages.

Use chrome.test.listenOnce to register event listeners in tests.
Note that there is no need for chrome.test.succeed for test cases
using listenOnce - it will get called once listener is run (unless
listener function asserts, in which case test will fail).

Refactors audio/test.js - added helper methods for testing
relevant properties of devices returned by chrome.audio.getInfo to
make expectations a bit easier to specify/understand.
The refactored test are less dependent on exact order in which
audio devices are reported in device list (as the order is of no
relevance).
==========

[commit-bot: I haz the power, 2016-11-03 20:00:09]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-03 20:03:51]

Description was changed from

==========
Refactor audio API tests

Instead of using custom messages to send test reuslts from test
app to test runner for tests for API events, use standard
extensions::ResultCatcher to get results - it workss better with
chrome.test.assert methods and produces better failure messages.

Use chrome.test.listenOnce to register event listeners in tests.
Note that there is no need for chrome.test.succeed for test cases
using listenOnce - it will get called once listener is run (unless
listener function asserts, in which case test will fail).

Refactors audio/test.js - added helper methods for testing
relevant properties of devices returned by chrome.audio.getInfo to
make expectations a bit easier to specify/understand.
The refactored test are less dependent on exact order in which
audio devices are reported in device list (as the order is of no
relevance).
==========

to

==========
Refactor audio API tests

Instead of using custom messages to send test reuslts from test
app to test runner for tests for API events, use standard
extensions::ResultCatcher to get results - it workss better with
chrome.test.assert methods and produces better failure messages.

Use chrome.test.listenOnce to register event listeners in tests.
Note that there is no need for chrome.test.succeed for test cases
using listenOnce - it will get called once listener is run (unless
listener function asserts, in which case test will fail).

Refactors audio/test.js - added helper methods for testing
relevant properties of devices returned by chrome.audio.getInfo to
make expectations a bit easier to specify/understand.
The refactored test are less dependent on exact order in which
audio devices are reported in device list (as the order is of no
relevance).

Committed: https://crrev.com/65dca4379e4a31128c1328c6d5e6b83840b4f9da
Cr-Commit-Position: refs/heads/master@{#429678}
==========

[commit-bot: I haz the power, 2016-11-03 20:03:52]

Patchset 6 (id:??) landed as
https://crrev.com/65dca4379e4a31128c1328c6d5e6b83840b4f9da
Cr-Commit-Position: refs/heads/master@{#429678}