third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp - Issue 2462803002: Plumb color space to DecodingImageGenerator and ImageFrameGenerator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

Issue 2462803002: Plumb color space to DecodingImageGenerator and ImageFrameGenerator (Closed)

Patch Set: Incorporate review feedback Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

index c49c01f99695e8a94a41e4827efe31486dea4151..0a810039b76fe2cc5a524abdf7644bab11a35be8 100644

--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

@@ -369,8 +369,10 @@ bool GIFImageDecoder::initFrameBuffer(size_t frameIndex) {

size_t requiredPreviousFrameIndex = buffer->requiredPreviousFrameIndex();

if (requiredPreviousFrameIndex == kNotFound) {

// This frame doesn't rely on any previous data.

- if (!buffer->setSizeAndColorSpace(size().width(), size().height(), nullptr))

+ if (!buffer->setSizeAndColorSpace(size().width(), size().height(),

+ colorSpace())) {

return setFailed();

+ }

} else {

ImageFrame* prevBuffer = &m_frameBufferCache[requiredPreviousFrameIndex];

ASSERT(prevBuffer->getStatus() == ImageFrame::FrameComplete);