third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp - Issue 2462803002: Plumb color space to DecodingImageGenerator and ImageFrameGenerator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

Issue 2462803002: Plumb color space to DecodingImageGenerator and ImageFrameGenerator (Closed)

Patch Set: Incorporate review feedback Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp ('k') | third_party/WebKit/Source/platform/graphics/ImageSource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp b/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

index 99ff17507562ea559c30f1a0b14e57f32bceb2da..293c6daf04b603be6f8c0e4518a0f20967dc7327 100644

--- a/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp

@@ -59,7 +59,7 @@ class ImageFrameGeneratorTest : public ::testing::Test,

public:

void SetUp() override {

ImageDecodingStore::instance().setCacheLimitInBytes(1024 * 1024);

- m_generator = ImageFrameGenerator::create(fullSize(), false);

+ m_generator = ImageFrameGenerator::create(fullSize(), nullptr, false);

m_data = SharedBuffer::create();

m_segmentReader = SegmentReader::createFromSharedBuffer(m_data);

useMockImageDecoderFactory();

@@ -110,7 +110,7 @@ class ImageFrameGeneratorTest : public ::testing::Test,

m_frameCount = count;

if (count > 1) {

m_generator.clear();

- m_generator = ImageFrameGenerator::create(fullSize(), true);

+ m_generator = ImageFrameGenerator::create(fullSize(), nullptr, true);

useMockImageDecoderFactory();

}