third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp - Issue 2462803002: Plumb color space to DecodingImageGenerator and ImageFrameGenerator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp

Issue 2462803002: Plumb color space to DecodingImageGenerator and ImageFrameGenerator (Closed)

Patch Set: Don't tag images just yet Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h ('K') | « third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h ('k') | third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp » ('j') | third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp b/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp

index 28d6d40e0825629836c45a0b5501b85cd8dd6994..2dc290507026d13b62fcfcef17cc25d1256b010f 100644

--- a/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp

+++ b/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp

@@ -104,8 +104,10 @@ static bool updateYUVComponentSizes(ImageDecoder* decoder,

}

ImageFrameGenerator::ImageFrameGenerator(const SkISize& fullSize,

+ sk_sp<SkColorSpace> colorSpace,

bool isMultiFrame)

: m_fullSize(fullSize),

+ m_colorSpace(colorSpace),

Justin Novosad 2016/10/31 14:55:13 std::move

ccameron 2016/10/31 18:10:17 Done.

m_isMultiFrame(isMultiFrame),

m_decodeFailed(false),

m_yuvDecodingFailed(false),