third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp - Issue 2462803002: Plumb color space to DecodingImageGenerator and ImageFrameGenerator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

Issue 2462803002: Plumb color space to DecodingImageGenerator and ImageFrameGenerator (Closed)

Patch Set: Don't tag images just yet Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h » ('j') | third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

index f1d9fab0f870d5452e9a8b48c1bd3584df7d731d..bccdb1244e7ceaafb8a42fe53b86f94cb8c79778 100644

--- a/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp

@@ -147,11 +147,11 @@ SkImageGenerator* DecodingImageGenerator::create(SkData* data) {

return nullptr;

const IntSize size = decoder->size();

- const SkImageInfo info =

- SkImageInfo::MakeN32Premul(size.width(), size.height());

+ const SkImageInfo info = SkImageInfo::MakeN32(

+ size.width(), size.height(), kPremul_SkAlphaType, decoder->colorSpace());

RefPtr<ImageFrameGenerator> frame = ImageFrameGenerator::create(

- SkISize::Make(size.width(), size.height()), false);

+ SkISize::Make(size.width(), size.height()), decoder->colorSpace(), false);

if (!frame)

return nullptr;