Plumb color space to DecodingImageGenerator and ImageFrameGenerator

third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.cpp

 /*
  * Copyright (c) 2008, 2009, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 103 matching lines @@
     return false;
 
   // Read and process the color table, if needed.
   if (m_needToProcessColorTable && !processColorTable())
     return false;
 
   // Initialize the framebuffer if needed.
   ASSERT(m_buffer);  // Parent should set this before asking us to decode!
   if (m_buffer->getStatus() == ImageFrame::FrameEmpty) {
     if (!m_buffer->setSizeAndColorSpace(m_parent->size().width(),
-                                        m_parent->size().height(), nullptr))
+                                        m_parent->size().height(),
+                                        m_parent->colorSpace())) {

[Justin Novosad, 2016/10/31 14:55:13]

don't we want to do this only if colorCorrectRendering is enabled?  same
question for all other decoders.

[ccameron, 2016/10/31 18:10:18]

Tagging input color spaces should have no effect, because only output color
space tagging triggers color correction.

That is, in theory. There is a bug
(https://bugs.chromium.org/p/skia/issues/detail?id=5907) where we fail to decode
scaled images when the color space isn't renderable, resulting in some images
ending up blank. I've added comments referencing that bug to the places where we
toss this value away.

Once that bug is fixed, I'll want to remove the checks, so that our inputs are
always tagged (just to limit the divergence hidden behind the flag).

       return m_parent->setFailed();  // Unable to allocate.
+    }
     m_buffer->setStatus(ImageFrame::FramePartial);
     // setSize() calls eraseARGB(), which resets the alpha flag, so we force
     // it back to false here.  We'll set it true below in all cases where
     // these 0s could actually show through.
     m_buffer->setHasAlpha(false);
 
     // For BMPs, the frame always fills the entire image.
     m_buffer->setOriginalFrameRect(IntRect(IntPoint(), m_parent->size()));
 
     if (!m_isTopDown)
@@ skipping 713 matching lines @@
 
   // Finished decoding whole image.
   return Success;
 }
 
 void BMPImageReader::moveBufferToNextRow() {
   m_coord.move(-m_coord.x(), m_isTopDown ? 1 : -1);
 }
 
 }  // namespace blink