Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

Issue 2462753002: Use Ash's ShelfWindowWatcher for app panel windows. (Closed)
Patch Set: Address comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shell/panel_window.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
index b9b0a4f2716fc3650fea762db835c48e4bfba401..44c677510d006fd28ef6247e2f04acd1a982dcfc 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
@@ -167,8 +167,6 @@ class ChromeLauncherControllerImpl
const ash::launcher::AppLauncherId& app_launcher_id,
int index);
- const std::string& GetAppIdFromShelfIdForTest(ash::ShelfID id);
-
private:
friend class ChromeLauncherControllerImplTest;
friend class ShelfAppBrowserTest;
@@ -238,7 +236,7 @@ class ChromeLauncherControllerImpl
LauncherItemController* controller);
// Create ShelfItem for Browser Shortcut.
- ash::ShelfID CreateBrowserShortcutLauncherItem();
+ void CreateBrowserShortcutLauncherItem();
// Check if the given |web_contents| is in incognito mode.
bool IsIncognito(const content::WebContents* web_contents) const;
« no previous file with comments | « ash/shell/panel_window.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698