ash/common/shelf/shelf_controller.cc - Issue 2462753002: Use Ash's ShelfWindowWatcher for app panel windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/shelf/shelf_controller.cc

Issue 2462753002: Use Ash's ShelfWindowWatcher for app panel windows. (Closed)

Patch Set: Add ShelfWindowWatcherTest, remove ChromeLauncherControllerImplTest panel use. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/shelf/shelf_controller.cc

diff --git a/ash/common/shelf/shelf_controller.cc b/ash/common/shelf/shelf_controller.cc

index 043fec9e7513655c295521b1b328c4b116ffe463..f68c86b8db8d7efdd77ffb5a408ee318909c5813 100644

--- a/ash/common/shelf/shelf_controller.cc

+++ b/ash/common/shelf/shelf_controller.cc

@@ -121,6 +121,8 @@ class ShelfItemDelegateMus : public ShelfItemDelegate {

bool ShouldShowTooltip() override { return true; }

+ bool IsOpen() const override { return true; }

void Close() override { NOTIMPLEMENTED(); }

mojom::ShelfItemDelegateAssociatedPtr delegate_;