Use Ash's ShelfWindowWatcher for app panel windows.

chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.h"
 
 #include "ash/common/wm/window_state.h"
 #include "ash/wm/window_state_aura.h"
 #include "ash/wm/window_util.h"
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item.h"
@@ skipping 36 matching lines @@
 }
 
 }  // namespace
 
 ExtensionAppWindowLauncherItemController::
     ExtensionAppWindowLauncherItemController(
         Type type,
         const std::string& app_id,
         const std::string& launch_id,
         ChromeLauncherController* controller)
-    : AppWindowLauncherItemController(type, app_id, launch_id, controller) {}
+    : AppWindowLauncherItemController(type, app_id, launch_id, controller) {
+  DCHECK_NE(TYPE_APP_PANEL, type);
+}
 
 ExtensionAppWindowLauncherItemController::
     ~ExtensionAppWindowLauncherItemController() {}
 
 void ExtensionAppWindowLauncherItemController::AddAppWindow(
     extensions::AppWindow* app_window) {
-  if (app_window->window_type_is_panel() && type() != TYPE_APP_PANEL)
-    LOG(ERROR) << "AppWindow of type Panel added to non-panel launcher item";
+  DCHECK(!app_window->window_type_is_panel());
   DCHECK(window_to_app_window_.find(app_window->GetBaseWindow()) ==
          window_to_app_window_.end());
   AddWindow(app_window->GetBaseWindow());
   window_to_app_window_[app_window->GetBaseWindow()] = app_window;
 }
 
 void ExtensionAppWindowLauncherItemController::OnWindowRemoved(
     ui::BaseWindow* window) {
   WindowToAppWindow::iterator it = window_to_app_window_.find(window);
   if (it == window_to_app_window_.end()) {
@@ skipping 29 matching lines @@
         index == 0 /* has_leading_separator */));
     ++index;
   }
   return items;
 }
 
 ash::ShelfItemDelegate::PerformedAction
 ExtensionAppWindowLauncherItemController::ItemSelected(const ui::Event& event) {
   if (windows().empty())
     return kNoAction;
-
-  if (type() == TYPE_APP_PANEL) {
-    DCHECK_EQ(windows().size(), 1u);
-    ui::BaseWindow* panel = windows().front();
-    aura::Window* panel_window = panel->GetNativeWindow();
-    // If the panel is attached on another display, move it to the current
-    // display and activate it.
-    if (ash::wm::GetWindowState(panel_window)->panel_attached() &&
-        ash::wm::MoveWindowToEventRoot(panel_window, event)) {
-      if (!panel->IsActive())
-        return ShowAndActivateOrMinimize(panel);
-    } else {
-      return ShowAndActivateOrMinimize(panel);
-    }
-  } else {
-    return AppWindowLauncherItemController::ItemSelected(event);
-  }
-  return kNoAction;
-}
-
-base::string16 ExtensionAppWindowLauncherItemController::GetTitle() {
-  // For panels return the title of the contents if set.
-  // Otherwise return the title of the app.
-  if (type() == TYPE_APP_PANEL && !windows().empty()) {
-    extensions::AppWindow* app_window =
-        window_to_app_window_[windows().front()];
-    DCHECK(app_window);
-    if (app_window->web_contents()) {
-      base::string16 title = app_window->web_contents()->GetTitle();
-      if (!title.empty())
-        return title;
-    }
-  }
-  return AppWindowLauncherItemController::GetTitle();
+  return AppWindowLauncherItemController::ItemSelected(event);
 }
 
 ash::ShelfMenuModel*
 ExtensionAppWindowLauncherItemController::CreateApplicationMenu(
     int event_flags) {
   return new LauncherApplicationMenuItemModel(GetApplicationList(event_flags));
 }
-
-bool ExtensionAppWindowLauncherItemController::IsDraggable() {
-  if (type() == TYPE_APP_PANEL)
-    return true;
-  return AppWindowLauncherItemController::IsDraggable();
-}
-
-bool ExtensionAppWindowLauncherItemController::ShouldShowTooltip() {
-  if (type() == TYPE_APP_PANEL && IsVisible())
-    return false;
-  return AppWindowLauncherItemController::ShouldShowTooltip();
-}