Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2462743003: Revert "Do nothing if [changeFile] reported, but the file content is the same." (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Do nothing if [changeFile] reported, but the file content is the same." This reverts commit 1ffda5601ba5af87248ae87d58e8cf6fcda48d8b. There is a bug with reporting changeFile() twice, first time the change be noticed and the file content hash updated. But the second time the content hash is the same, and we unschedule the file from analysis :-( R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1bdee25bdfbd5fd29f17f24236813244f76e03fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -42 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 4 chunks +7 lines, -17 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 2 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-10-29 01:06:40 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as 1bdee25bdfbd5fd29f17f24236813244f76e03fd (presubmit successful).
4 years, 1 month ago (2016-10-29 01:06:53 UTC) #3
Brian Wilkerson
4 years, 1 month ago (2016-10-31 14:06:54 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698