Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2462703002: Improving non-square large icon in MediaNotification (Closed)

Created:
4 years, 1 month ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 1 month ago
Reviewers:
whywhat
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improving non-square large icon in MediaNotification This CL improves non-square large icon in MediaNotification by: * Giving penalty score to non-square image. * Rescalling non-square image while keeping the aspect ratio (paddings added). BUG=656028 Committed: https://crrev.com/76252384438261f0c575e22296d5776a7e7f4f47 Cr-Commit-Position: refs/heads/master@{#428691}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java View 1 3 chunks +23 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 2 chunks +25 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Zhiqiang Zhang (Slow)
4 years, 1 month ago (2016-10-28 19:53:21 UTC) #2
whywhat
lgtm do you have example sites/images? does it look better than if we crop the ...
4 years, 1 month ago (2016-10-28 20:19:26 UTC) #3
Zhiqiang Zhang (Slow)
On 2016/10/28 20:19:26, whywhat wrote: > lgtm > > do you have example sites/images? does ...
4 years, 1 month ago (2016-10-28 20:49:24 UTC) #4
whywhat
On 2016/10/28 at 20:49:24, zqzhang wrote: > On 2016/10/28 20:19:26, whywhat wrote: > > lgtm ...
4 years, 1 month ago (2016-10-29 05:18:26 UTC) #5
Zhiqiang Zhang (Slow)
https://codereview.chromium.org/2462703002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java (right): https://codereview.chromium.org/2462703002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java#newcode37 chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:37: * - The dominant size score lies in [0, ...
4 years, 1 month ago (2016-10-31 12:08:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462703002/20001
4 years, 1 month ago (2016-10-31 12:08:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 12:37:37 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 12:39:43 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76252384438261f0c575e22296d5776a7e7f4f47
Cr-Commit-Position: refs/heads/master@{#428691}

Powered by Google App Engine
This is Rietveld 408576698