Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1468)

Unified Diff: chrome/browser/ui/webui/signin/login_ui_service.cc

Issue 2462603002: Use the modal view when signing in from chrome.identity extension API. (Closed)
Patch Set: Revert changes in profile_chooser_controller.mm Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/signin/login_ui_service.cc
diff --git a/chrome/browser/ui/webui/signin/login_ui_service.cc b/chrome/browser/ui/webui/signin/login_ui_service.cc
index 8fe5bf989ff93035c6a9e8ea74e075a56ab17419..9250df6b405dab3bd918e3d1a5251356c508aea7 100644
--- a/chrome/browser/ui/webui/signin/login_ui_service.cc
+++ b/chrome/browser/ui/webui/signin/login_ui_service.cc
@@ -10,6 +10,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/chrome_pages.h"
+#include "chrome/browser/ui/profile_chooser_constants.h"
#include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
#include "chrome/common/url_constants.h"
@@ -57,9 +58,15 @@ void LoginUIService::ShowLoginPopup() {
NOTREACHED();
#else
chrome::ScopedTabbedBrowserDisplayer displayer(profile_);
- chrome::ShowBrowserSignin(
- displayer.browser(),
- signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);
+ profiles::BubbleViewMode signin_mode = profiles::BUBBLE_VIEW_MODE_GAIA_SIGNIN;
+ if (SigninViewController::ShouldShowModalSigninForMode(signin_mode)) {
+ displayer.browser()->ShowModalSigninWindow(signin_mode,
+ signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);
+ } else {
+ chrome::ShowBrowserSignin(
+ displayer.browser(),
+ signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);
+ }
#endif
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698