Use the modal view when signing in from chrome.identity extension API.

Use the modal view when signing in from chrome.identity extension API.

BUG=652791
Committed: https://crrev.com/8122f2f2f0ba7bd36c264f03dd6201232335bdcb
Cr-Commit-Position: refs/heads/master@{#429556}

[msarda, 2016-10-28 13:32:48]

Description was changed from

==========
Use the modal view when signing in from chrome.identity extension API


BUG=652791
==========

to

==========
Use the modal view when signing in from chrome.identity extension API.

BUG=652791
==========

[msarda, 2016-10-28 16:15:23]

msarda@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[msarda, 2016-10-28 16:15:24]

Please take a look.

[anthonyvd, 2016-11-02 19:45:33]

lgtm

[msarda, 2016-11-03 09:41:37]

The CQ bit was checked by msarda@chromium.org

[commit-bot: I haz the power, 2016-11-03 09:42:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 11:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 11:42:24]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[msarda, 2016-11-03 11:54:25]

The CQ bit was checked by msarda@chromium.org

[commit-bot: I haz the power, 2016-11-03 11:54:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 13:21:59]

Description was changed from

==========
Use the modal view when signing in from chrome.identity extension API.

BUG=652791
==========

to

==========
Use the modal view when signing in from chrome.identity extension API.

BUG=652791
==========

[commit-bot: I haz the power, 2016-11-03 13:22:00]

Committed patchset #2 (id:10001)

[commit-bot: I haz the power, 2016-11-03 13:24:57]

Description was changed from

==========
Use the modal view when signing in from chrome.identity extension API.

BUG=652791
==========

to

==========
Use the modal view when signing in from chrome.identity extension API.

BUG=652791

Committed: https://crrev.com/8122f2f2f0ba7bd36c264f03dd6201232335bdcb
Cr-Commit-Position: refs/heads/master@{#429556}
==========

[commit-bot: I haz the power, 2016-11-03 13:24:58]

Patchset 2 (id:??) landed as
https://crrev.com/8122f2f2f0ba7bd36c264f03dd6201232335bdcb
Cr-Commit-Position: refs/heads/master@{#429556}

[msarda, 2016-12-02 12:36:27]

I'll revert this CL as it is responsible for crash
https://bugs.chromium.org/p/chromium/issues/detail?id=667750

[msarda, 2016-12-02 12:37:23]

A revert of this CL (patchset #2 id:10001) has been created in
https://codereview.chromium.org/2542423002/ by msarda@chromium.org.

The reason for reverting is: This CL as it is responsible for crash
https://bugs.chromium.org/p/chromium/issues/detail?id=667750.