Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2462603002: Use the modal view when signing in from chrome.identity extension API. (Closed)

Created:
4 years, 1 month ago by msarda
Modified:
4 years ago
Reviewers:
anthonyvd
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the modal view when signing in from chrome.identity extension API. BUG=652791 Committed: https://crrev.com/8122f2f2f0ba7bd36c264f03dd6201232335bdcb Cr-Commit-Position: refs/heads/master@{#429556}

Patch Set 1 #

Patch Set 2 : Revert changes in profile_chooser_controller.mm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/ui/webui/signin/login_ui_service.cc View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
msarda
Please take a look.
4 years, 1 month ago (2016-10-28 16:15:24 UTC) #3
anthonyvd
lgtm
4 years, 1 month ago (2016-11-02 19:45:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462603002/10001
4 years, 1 month ago (2016-11-03 09:42:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-03 11:42:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462603002/10001
4 years, 1 month ago (2016-11-03 11:54:42 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:10001)
4 years, 1 month ago (2016-11-03 13:22:00 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8122f2f2f0ba7bd36c264f03dd6201232335bdcb Cr-Commit-Position: refs/heads/master@{#429556}
4 years, 1 month ago (2016-11-03 13:24:58 UTC) #14
msarda
I'll revert this CL as it is responsible for crash https://bugs.chromium.org/p/chromium/issues/detail?id=667750
4 years ago (2016-12-02 12:36:27 UTC) #15
msarda
4 years ago (2016-12-02 12:37:23 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:10001) has been created in
https://codereview.chromium.org/2542423002/ by msarda@chromium.org.

The reason for reverting is: This CL as it is responsible for crash
https://bugs.chromium.org/p/chromium/issues/detail?id=667750.

Powered by Google App Engine
This is Rietveld 408576698