Fix endBatchEdit() state update order issue

Fix endBatchEdit() state update order issue

If we call endBatchEdit() and then call getExtractedText() immediately,
then the order gets reversed.

The reason is that getExtractedText() is already block-waiting for a new
state, and endBatchEdit() was piggy-backing on FROM_IME to enforce a
state update.

The more natural change source for a state update at the end of a batch
edit is actually FROM_NON_IME, which does not interfere with the
block-wait mechanism of get* methods. The state update order in the above
scenario is fixed because blockAndGetStateUpdate() handles it correctly
when it's FROM_NON_IME.

Also, now we bounce state update in RenderWidget instead of doing so in
ThreadedInputConnection. This is another way to make sure that we get
state update at the end of batch edit: the intermediate state update was
already bounced off.

Now there is no need to check isInBatchEdit() inside
ThreadedInputConnection, and ThreadedInputConnectionTest needs to be
updated, but let me handle them in a separate CL.

BUG=659934
Committed: https://crrev.com/72381b3189537b4e3c7e2dbff8a2ca398bd3b447
Cr-Commit-Position: refs/heads/master@{#428602}

[Changwan Ryu, 2016-10-29 03:44:19]

The CQ bit was checked by changwan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-29 03:44:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Changwan Ryu, 2016-10-29 03:44:59]

changwan@chromium.org changed reviewers:
+ aelias@chromium.org

[Changwan Ryu, 2016-10-29 03:44:59]

PTAL

[aelias_OOO_until_Jul13, 2016-10-29 04:45:50]

lgtm

[commit-bot: I haz the power, 2016-10-29 04:56:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-29 04:56:30]

Dry run: This issue passed the CQ dry run.

[Changwan Ryu, 2016-10-29 05:03:17]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2016-10-29 05:03:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 05:08:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-29 05:10:51]

Description was changed from

==========
Fix endBatchEdit() state update order issue

If we call endBatchEdit() and then call getExtractedText() immediately,
then the order gets reversed.

The reason is that getExtractedText() is already block-waiting for a new
state, and endBatchEdit() was piggy-backing on FROM_IME to enforce a
state update.

The more natural change source for a state update at the end of a batch
edit is actually FROM_NON_IME, which does not interfere with the
block-wait mechanism of get* methods. The state update order in the above
scenario is fixed because blockAndGetStateUpdate() handles it correctly
when it's FROM_NON_IME.

Also, now we bounce state update in RenderWidget instead of doing so in
ThreadedInputConnection. This is another way to make sure that we get
state update at the end of batch edit: the intermediate state update was
already bounced off.

Now there is no need to check isInBatchEdit() inside
ThreadedInputConnection, and ThreadedInputConnectionTest needs to be
updated, but let me handle them in a separate CL.

BUG=659934
==========

to

==========
Fix endBatchEdit() state update order issue

If we call endBatchEdit() and then call getExtractedText() immediately,
then the order gets reversed.

The reason is that getExtractedText() is already block-waiting for a new
state, and endBatchEdit() was piggy-backing on FROM_IME to enforce a
state update.

The more natural change source for a state update at the end of a batch
edit is actually FROM_NON_IME, which does not interfere with the
block-wait mechanism of get* methods. The state update order in the above
scenario is fixed because blockAndGetStateUpdate() handles it correctly
when it's FROM_NON_IME.

Also, now we bounce state update in RenderWidget instead of doing so in
ThreadedInputConnection. This is another way to make sure that we get
state update at the end of batch edit: the intermediate state update was
already bounced off.

Now there is no need to check isInBatchEdit() inside
ThreadedInputConnection, and ThreadedInputConnectionTest needs to be
updated, but let me handle them in a separate CL.

BUG=659934

Committed: https://crrev.com/72381b3189537b4e3c7e2dbff8a2ca398bd3b447
Cr-Commit-Position: refs/heads/master@{#428602}
==========

[commit-bot: I haz the power, 2016-10-29 05:10:52]

Patchset 1 (id:??) landed as
https://crrev.com/72381b3189537b4e3c7e2dbff8a2ca398bd3b447
Cr-Commit-Position: refs/heads/master@{#428602}

[Changwan Ryu, 2016-10-29 16:31:51]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2463583002/ by changwan@chromium.org.

The reason for reverting is: As pointed out in
https://bugs.chromium.org/p/chromium/issues/detail?id=659934#c23, keyboard may
not show up when it has to with this patch..