Multiprofile: switch to newly added user to the session

Multiprofile: switch to newly added user to the session

This CL remember pending user switch and do it as soon as profile
ready. From UI perspective this look very smooth because profile loading
is actually fast so previous desktop is not shown. But if it will be
a problem on slow device we may need to stay on add user screen a bit longer.

BUG=333879
TEST=manual
R=nkostylev@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266239

[Dmitry Polukhin, 2014-04-24 19:41:24]

PTAL

[Nikita (slow), 2014-04-25 15:00:07]

lgtm

https://codereview.chromium.org/246253009/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/user_manager_impl.cc (left):

https://codereview.chromium.org/246253009/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/user_manager_impl.cc:428:
WallpaperManager::Get()->SetUserWallpaperNow(active_user_->email());
So I guess we don't need to switch wallpaper now since we have correct one that
was activated on mp login.

https://codereview.chromium.org/246253009/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/preferences_browsertest.cc (right):

https://codereview.chromium.org/246253009/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/preferences_browsertest.cc:164: // Check that settings
was changed accordingly.
nit: were changed.

[Dmitry Polukhin, 2014-04-25 16:07:20]

https://codereview.chromium.org/246253009/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/login/user_manager_impl.cc (left):

https://codereview.chromium.org/246253009/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/login/user_manager_impl.cc:428:
WallpaperManager::Get()->SetUserWallpaperNow(active_user_->email());
On 2014/04/25 15:00:08, Nikita Kostylev wrote:
> So I guess we don't need to switch wallpaper now since we have correct one
that
> was activated on mp login.

Yes, new user wallpaper is set when his pod activated.

https://codereview.chromium.org/246253009/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/preferences_browsertest.cc (right):

https://codereview.chromium.org/246253009/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/preferences_browsertest.cc:164: // Check that settings
was changed accordingly.
On 2014/04/25 15:00:08, Nikita Kostylev wrote:
> nit: were changed.

Done.

[Dmitry Polukhin, 2014-04-25 16:07:24]

The CQ bit was checked by dpolukhin@chromium.org

[dpolukhin, 2014-04-25 21:01:03]

Committed patchset #4 manually as r266239 (presubmit successful).

[Nikita (slow), 2014-04-30 10:58:34]

A revert of this CL has been created in
https://codereview.chromium.org/257393003/ by nkostylev@chromium.org.

The reason for reverting is: Suspecting this change as a root cause for
superflaky UserAddingScreenTest.AddingSeveralUsers

See http://crbug.com/368621.