Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 246253008: Adjust Screen's derived Oilpan type after r172152 (Closed)

Created:
6 years, 8 months ago by sof
Modified:
6 years, 8 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Adjust Screen's derived Oilpan type after r172152 Following r172152, Screen is no longer an EventTarget. Hence we can simplify it to derive from GarbageCollectedFinalized only. R= BUG=162827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/frame/Screen.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
please take a look.
6 years, 8 months ago (2014-04-22 19:13:20 UTC) #1
tkent
lgtm
6 years, 8 months ago (2014-04-22 22:36:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/246253008/1
6 years, 8 months ago (2014-04-22 22:36:45 UTC) #3
haraken
LGTM
6 years, 8 months ago (2014-04-22 23:03:32 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 23:45:14 UTC) #5
Message was sent while issue was closed.
Change committed as 172289

Powered by Google App Engine
This is Rietveld 408576698