Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 246253006: Fixed routing id in WebPluginProxy::CheckIfRunInsecureContent (Closed)

Created:
6 years, 8 months ago by kjakubowski
Modified:
6 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed routing id in WebPluginProxy::CheckIfRunInsecureContent. Wrong routing id in this function may cause a hang on some web-pages (process will wait for a response after sending a message which never gets delivered). Message PluginHostMsg_CheckIfRunInsecureContent is handled in WebPluginDelegateProxy::OnMessageReceived, so instead of host_render_view_routing_id_, route_id_ should be used (just like in WebPluginProxy::URLRedirectResponse). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265913

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/plugin/webplugin_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
kjakubowski
Hi, I've noticed a small problem in WebPluginProxy::CheckIfRunInsecureContent. Can you please take a quick look ...
6 years, 8 months ago (2014-04-23 08:03:11 UTC) #1
jam
lgtm
6 years, 8 months ago (2014-04-23 19:41:21 UTC) #2
kjakubowski
The CQ bit was checked by kjakubowski@opera.com
6 years, 8 months ago (2014-04-24 08:18:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjakubowski@opera.com/246253006/1
6 years, 8 months ago (2014-04-24 08:26:16 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 09:15:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-24 09:15:19 UTC) #6
kjakubowski
The CQ bit was checked by kjakubowski@opera.com
6 years, 8 months ago (2014-04-24 09:32:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjakubowski@opera.com/246253006/1
6 years, 8 months ago (2014-04-24 09:33:01 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 11:44:02 UTC) #9
Message was sent while issue was closed.
Change committed as 265913

Powered by Google App Engine
This is Rietveld 408576698