Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6816)

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html

Issue 2462483002: Support multi-line braille in the virtual braille display. (Closed)
Patch Set: Addressed Review comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
index 6d189e80e1e66fd6ac8d778e4697964d64be11fd..f0a593e5888cf9c6406eca045735432460bcd283 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
@@ -85,10 +85,29 @@
</span>
</label>
</div>
-
<br><br>
</div>
+ <h2 class="i18n" msgid="options_virtual_braille_display">Virtual Braille Display</h2>
+ <label >
dmazzoni 2016/10/28 20:19:18 nit: no space before the closing >
ultimatedbz 2016/10/28 23:51:43 Done.
+ <div>
+ <span class="i18n description" msgid="options_virtual_braille_display_rows" id="virtual_braille_display_rows_description">
+ Rows:
+ </span>
+ </div>
+ <input type="number" min="1" id="virtual_braille_display_rows_input">
dmazzoni 2016/10/28 20:19:18 Maybe we should have a max of 99 so that it doesn'
ultimatedbz 2016/10/28 23:51:43 Done.
+ </label>
+ <label >
+ <div>
+ <span class="i18n description" msgid="options_virtual_braille_display_columns" id="virtual_braille_display_columns_description">
+ Columns:
+ </span>
+ </div>
+ <input type="number" min="1" id="virtual_braille_display_columns_input">
+ </label>
+
+ <div id="currentDisplayStyle"></div>
+ <button id="changeDisplayStyle"></button>
<h2 class="i18n" msgid="options_keyboard_shortcuts">Keyboard shortcuts</h2>
<p class="i18n description" msgid="options_keymap_description" id="keymap_description">
@@ -104,6 +123,15 @@
<br><br>
</div>
+ <p class="i18n description" msgid="options_shortcuts_description"
dmazzoni 2016/10/28 20:19:18 I think this is a merge error. David recently dele
ultimatedbz 2016/10/28 23:51:43 Oh! My bad. I will be more careful the next time I
+ id="shortcuts_description">
+ Customize keyboard shortcuts for frequently used commands by typing them into the
+ corresponding fields below.
+ </p>
+
+ <div id="keysContainer">
+
+ </div>
<div id="status" role="live" aria-live="assertive">
</div>
</div>

Powered by Google App Engine
This is Rietveld 408576698