chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js - Issue 2462483002: Support multi-line braille in the virtual braille display.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

Issue 2462483002: Support multi-line braille in the virtual braille display. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html » ('j') | chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

diff --git a/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js b/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

index ba81490b477a353603b5033a13c0ebce1adda9f8..64cd3eaedd0bbac6027eea4e1ae93c3afc65ff96 100644

--- a/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

+++ b/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

@@ -245,7 +245,7 @@ cvox.BrailleDisplayManager.prototype.translateContent_ = function(

translatedEndIndex = textToBraille[endIndex];

}

this.translatedContent_ = cells;

- // Copy the transalted content to a separate buffer and add the cursor

+ // Copy the translated content to a separate buffer and add the cursor

dmazzoni 2016/10/28 06:19:29 Thanks for fixing this!

ultimatedbz 2016/10/28 18:45:34 Woo!

// to it.

this.displayedContent_ = new ArrayBuffer(cells.byteLength);

new Uint8Array(this.displayedContent_).set(new Uint8Array(cells));