[Payments] Don't show select when clicking in billing address drop.

[Payments] Don't show select when clicking in billing address drop.

BUG=660207
Committed: https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201
Cr-Commit-Position: refs/heads/master@{#429023}

[sebsg, 2016-10-31 13:33:38]

Patchset #1 (id:1) has been deleted

[sebsg, 2016-10-31 14:57:11]

Patchset #1 (id:20001) has been deleted

[sebsg, 2016-10-31 15:04:35]

Patchset #1 (id:40001) has been deleted

[sebsg, 2016-10-31 17:03:28]

Patchset #1 (id:60001) has been deleted

[sebsg, 2016-10-31 18:32:46]

Patchset #3 (id:110001) has been deleted

[sebsg, 2016-10-31 18:36:44]

sebsg@chromium.org changed reviewers:
+ rouslan@chromium.org

[sebsg, 2016-10-31 18:36:45]

Hi Rouslan, PTAL?

[sebsg, 2016-10-31 18:36:55]

Description was changed from

==========
WIP [Payments] Don't show select when clicking in billing address drop.

BUG=660207
==========

to

==========
[Payments] Don't show select when clicking in billing address drop.

BUG=660207
==========

[sebsg, 2016-10-31 19:50:03]

Patchset #4 (id:150001) has been deleted

[please use gerrit instead, 2016-10-31 20:08:26]

overall lgtm after you address the comments please

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
(right):

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:71:
private static final String BILLING_ADDRESS_NONE = "";
You can remove this now.

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
(right):

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java:68:
// If no value is selected, select the hint entry.
Add to the comment that adapter.getCount() is not out of bounds, because the
count is one fewer that the number of items in the adapter.

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
(right):

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:228:
* @param hint              The hint to be displayed when no value is selected.
Can you add an optional hint to the createDropdown() above instead? That might
make the code more concise, I hope.

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:385:
public CharSequence getHint() {
assert mInputTypeHint == INPUT_TYPE_HINT_DROPDOWN;

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/HintArrayAdapter.java
(right):

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/HintArrayAdapter.java:14:
* options. Insert the element to be used as a hint last.
s/Insert the element to be used as a hint last/The last element is the hint/g

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/HintArrayAdapter.java:26:
* @param objects  The objects to represent in the ListView.
... the last of which is not displayed in the dropdown, but is used as the hint.

[sebsg, 2016-11-01 15:49:26]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2016-11-01 15:49:26]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2462473002/#ps190001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-11-01 15:49:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 16:48:47]

Description was changed from

==========
[Payments] Don't show select when clicking in billing address drop.

BUG=660207
==========

to

==========
[Payments] Don't show select when clicking in billing address drop.

BUG=660207
==========

[commit-bot: I haz the power, 2016-11-01 16:48:48]

Committed patchset #5 (id:190001)

[commit-bot: I haz the power, 2016-11-01 17:22:31]

Description was changed from

==========
[Payments] Don't show select when clicking in billing address drop.

BUG=660207
==========

to

==========
[Payments] Don't show select when clicking in billing address drop.

BUG=660207

Committed: https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201
Cr-Commit-Position: refs/heads/master@{#429023}
==========

[commit-bot: I haz the power, 2016-11-01 17:22:32]

Patchset 5 (id:??) landed as
https://crrev.com/7076c12477de96ee12e819b05e2e559cf8120201
Cr-Commit-Position: refs/heads/master@{#429023}

[sebsg, 2016-11-01 17:57:18]

Thanks. Commited

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
(right):

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java:71:
private static final String BILLING_ADDRESS_NONE = "";
On 2016/10/31 20:08:25, rouslan wrote:
> You can remove this now.

Done.

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
(right):

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java:68:
// If no value is selected, select the hint entry.
On 2016/10/31 20:08:25, rouslan wrote:
> Add to the comment that adapter.getCount() is not out of bounds, because the
> count is one fewer that the number of items in the adapter.

Done.

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
(right):

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:228:
* @param hint              The hint to be displayed when no value is selected.
On 2016/10/31 20:08:25, rouslan wrote:
> Can you add an optional hint to the createDropdown() above instead? That might
> make the code more concise, I hope.

Done.

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:385:
public CharSequence getHint() {
On 2016/10/31 20:08:25, rouslan wrote:
> assert mInputTypeHint == INPUT_TYPE_HINT_DROPDOWN;

Done.

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/HintArrayAdapter.java
(right):

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/HintArrayAdapter.java:14:
* options. Insert the element to be used as a hint last.
On 2016/10/31 20:08:26, rouslan wrote:
> s/Insert the element to be used as a hint last/The last element is the hint/g

Done.

https://codereview.chromium.org/2462473002/diff/170001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/HintArrayAdapter.java:26:
* @param objects  The objects to represent in the ListView.
On 2016/10/31 20:08:25, rouslan wrote:
> ... the last of which is not displayed in the dropdown, but is used as the
hint.

Done.