Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: net/spdy/bidirectional_stream_spdy_impl.h

Issue 2462463002: Make net::BidirectionalStream handle RST_STREAM_NO_ERROR (Closed)
Patch Set: Address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/bidirectional_stream_spdy_impl.h
diff --git a/net/spdy/bidirectional_stream_spdy_impl.h b/net/spdy/bidirectional_stream_spdy_impl.h
index 1e5e782bbbf8ffbab4c0f71613a6a81d23016696..f9fa2253c37a98f42e46dec196828a071f7fb0d2 100644
--- a/net/spdy/bidirectional_stream_spdy_impl.h
+++ b/net/spdy/bidirectional_stream_spdy_impl.h
@@ -74,10 +74,14 @@ class NET_EXPORT_PRIVATE BidirectionalStreamSpdyImpl
void OnStreamInitialized(int rv);
// Notifies delegate of an error.
void NotifyError(int rv);
+ void NotifyDataSent();
void ResetStream();
void ScheduleBufferedRead();
void DoBufferedRead();
bool ShouldWaitForMoreBufferedData() const;
+ // Handles the case where stream is closed when SendData()/SendvData() is
+ // called. Return true if stream is closed.
+ bool MaybeHandleStreamClosedInSendData();
const base::WeakPtr<SpdySession> spdy_session_;
const BidirectionalStreamRequestInfo* request_info_;
@@ -96,6 +100,12 @@ class NET_EXPORT_PRIVATE BidirectionalStreamSpdyImpl
scoped_refptr<IOBuffer> read_buffer_;
int read_buffer_len_;
+ // Whether client has written the end of stream flag in request headers or
+ // in SendData()/SendvData().
+ bool written_end_of_stream_;
+ // Whether a SendData() or SendvData() is pending.
+ bool write_pending_;
+
// Whether OnClose has been invoked.
bool stream_closed_;
// Status reported in OnClose.
« no previous file with comments | « no previous file | net/spdy/bidirectional_stream_spdy_impl.cc » ('j') | net/spdy/bidirectional_stream_spdy_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698