Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2462433003: Fix compilation error on OSX 10.12. (Closed)

Created:
4 years, 1 month ago by pwnall
Modified:
4 years, 1 month ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org, spqchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compilation error on OSX 10.12. chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm does not include the header for a class that it uses, BrowserWindowController. This CL adds the missing include and fixes the OSX 10.12 build error documented in the associated bug. BUG=660292 Committed: https://crrev.com/7fcceb13d277f6f7fd3bed8843de3bb8495faecd Cr-Commit-Position: refs/heads/master@{#428351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
pwnall
PTAL?
4 years, 1 month ago (2016-10-28 06:24:26 UTC) #4
Robert Sesek
lgtm
4 years, 1 month ago (2016-10-28 13:13:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462433003/1
4 years, 1 month ago (2016-10-28 13:13:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 13:19:44 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 13:23:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fcceb13d277f6f7fd3bed8843de3bb8495faecd
Cr-Commit-Position: refs/heads/master@{#428351}

Powered by Google App Engine
This is Rietveld 408576698