Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 246243002: cros: Fix crash on start up on device. (Closed)

Created:
6 years, 8 months ago by sadrul
Modified:
6 years, 8 months ago
Reviewers:
oshima, michaelpg
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

cros: Fix crash on start up on device. The SystemKeyEventListener needs to be initialized after aura::Env has been initialized, since it depends on the existence of the event-source, and Env creates the event-source. BUG=354062 R=michaelpg@chromium.org, oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
6 years, 8 months ago (2014-04-22 01:50:17 UTC) #1
michaelpg
LGTM -- this fixes the crash on my Pixel.
6 years, 8 months ago (2014-04-22 03:27:31 UTC) #2
sadrul
On 2014/04/22 03:27:31, Michael Giuffrida wrote: > LGTM -- this fixes the crash on my ...
6 years, 8 months ago (2014-04-22 03:45:25 UTC) #3
oshima
lgtm
6 years, 8 months ago (2014-04-22 04:06:16 UTC) #4
sadrul
6 years, 8 months ago (2014-04-22 04:37:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r265156 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698