Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2462383002: Revert "Enable MidiManagerWinrt by default on Windows 10" (Closed)

Created:
4 years, 1 month ago by Shao-Chuan Lee
Modified:
4 years, 1 month ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert "Enable MidiManagerWinrt by default on Windows 10" Make MidiManagerWinrt back behind a Finch flag disabled by default. Reverting CL https://codereview.chromium.org/2392263002/ while preserving strings and histograms for the "disabled" flag. Revert this CL to enable it by default again. BUG=645403, 659458 TBR=shaochuan@chromium.org,toyoshim@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M media/midi/midi_manager_win.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M media/midi/midi_switches.h View 1 chunk +10 lines, -2 lines 0 comments Download
M media/midi/midi_switches.cc View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Shao-Chuan Lee
Merging to M55 (branch 2883), could you help submitting this by 8am (JST) tomorrow if ...
4 years, 1 month ago (2016-11-01 04:28:15 UTC) #2
Shao-Chuan Lee
Next beta release will use the same branch, this CL is still valid. PTAL
4 years, 1 month ago (2016-11-02 06:39:07 UTC) #3
Takashi Toyoshima
lgtm
4 years, 1 month ago (2016-11-07 06:20:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462383002/1
4 years, 1 month ago (2016-11-07 06:22:06 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 1 month ago (2016-11-07 06:22:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462383002/1
4 years, 1 month ago (2016-11-07 06:30:10 UTC) #12
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
4 years, 1 month ago (2016-11-07 06:32:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2462383002/20001
4 years, 1 month ago (2016-11-07 06:35:38 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 06:38:09 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698