Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2340)

Unified Diff: base/android/linker/config.gni

Issue 2462333002: Crazylinker: remove the code to load component build library (Closed)
Patch Set: Revert "Revert of Crazylinker: remove the code to load component build library (patchset #4 id:6000… Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/java/src/org/chromium/base/library_loader/Linker.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/linker/config.gni
diff --git a/base/android/linker/config.gni b/base/android/linker/config.gni
index 174c1abe7ee31bfb8ecd57244ccaad1cf49c45c7..26980c468db311cf4a2efcd614b9eea0ab62898e 100644
--- a/base/android/linker/config.gni
+++ b/base/android/linker/config.gni
@@ -7,6 +7,7 @@ import("//build/config/compiler/compiler.gni")
import("//build/config/sanitizers/sanitizers.gni")
# Chromium linker crashes on component builds on Android 4.4. See b/11379966
-# Chromium linker causes instrumentation to return incorrect results.
+# Chromium linker doesn't reliably support loading multiple libraries;
Torne 2016/11/01 13:35:51 This is still replacing the wrong comment. We want
Torne 2016/11/02 09:57:15 What I expected the comments to say: # Chromium l
michaelbai 2016/11/02 15:36:43 In this way, b/11379966 is dropped, you think it i
+# disable for component builds, see crbug.com/657093.
chromium_linker_supported =
!is_component_build && !enable_profiling && !use_order_profiling && !is_asan
« no previous file with comments | « base/android/java/src/org/chromium/base/library_loader/Linker.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698