Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 246233005: Remove WebPasswordFormData and util files (Closed)

Created:
6 years, 8 months ago by ziran.sun
Modified:
6 years, 7 months ago
Reviewers:
tkent, Garrett Casto
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove WebPasswordFormData and util files Functioins in there files have been rewritten in components/autofill/content/renderer/password_form_conversion_utils. This is to refact old Blink code on WebPasswordFormData and utils files. R=gcasto@chromium.org, tkent BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -478 lines) Patch
D Source/web/WebPasswordFormData.cpp View 1 chunk +0 lines, -182 lines 0 comments Download
D Source/web/WebPasswordFormUtils.h View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/web/WebPasswordFormUtils.cpp View 1 chunk +0 lines, -104 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
D public/web/WebPasswordFormData.h View 1 chunk +0 lines, -126 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ziran.sun
Remove WebPasswordFormData and util files in blink code. Only Land this CL after the following ...
6 years, 8 months ago (2014-04-22 15:28:33 UTC) #1
tkent
lgtm
6 years, 8 months ago (2014-04-22 22:41:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/246233005/1
6 years, 8 months ago (2014-04-22 22:42:26 UTC) #3
Garrett Casto
The CQ bit was unchecked by gcasto@chromium.org
6 years, 8 months ago (2014-04-22 22:48:01 UTC) #4
ziran.sun
The CQ bit was checked by ziran.sun@samsung.com
6 years, 7 months ago (2014-04-29 13:49:20 UTC) #5
ziran.sun
The CQ bit was unchecked by ziran.sun@samsung.com
6 years, 7 months ago (2014-04-29 13:49:20 UTC) #6
ziran.sun
The CQ bit was checked by ziran.sun@samsung.com
6 years, 7 months ago (2014-04-30 16:34:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/246233005/1
6 years, 7 months ago (2014-04-30 16:34:25 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 16:35:00 UTC) #9
Message was sent while issue was closed.
Change committed as 172999

Powered by Google App Engine
This is Rietveld 408576698