Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2462213002:
Upgrade libsrtp to version 2.0 (Closed)
|
Created:
4 years, 1 month ago by mattdr-at-chromium Modified:
4 years, 1 month ago CC:
chromium-reviews Target Ref:
refs/pending/branch-heads/2883 Project:
chromium Visibility:
Public. |
DescriptionUpgrade libsrtp to version 2.0
Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client.
Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits).
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63..71692eaab2a0
$ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s'
2016-10-20 kjellander Only build libsrtp tests if a build flag is set
2016-10-20 kjellander Don't build tests on Windows.
2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0
BUG=625878
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://chromiumcodereview.appspot.com/2436913003
Cr-Commit-Position: refs/heads/master@{#426814}
(cherry picked from commit c2eb0266eee3348b00ad3cdc1261d71cefe47333)
Patch Set 1 #
Messages
Total messages: 29 (15 generated)
mattdr@chromium.org changed reviewers: + kjellander@chromium.org
Cherry-pick into release branch.
The CQ bit was checked by mattdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
On 2016/10/31 20:47:13, mattdr-at-chromium wrote: > Cherry-pick into release branch. 2883 is the current beta branch according to https://omahaproxy.appspot.com/. To be able to merge to that you need to file a separate bug at crbug.com, link to it from this CL and get merge approval for it.
On 2016/10/31 20:54:55, kjellander_chromium wrote: > On 2016/10/31 20:47:13, mattdr-at-chromium wrote: > > Cherry-pick into release branch. > > 2883 is the current beta branch according to https://omahaproxy.appspot.com/. > To be able to merge to that you need to file a separate bug at http://crbug.com, link > to it from this CL and get merge approval for it. https://bugs.chromium.org/p/chromium/issues/detail?id=625878#c24
Description was changed from ========== Upgrade libsrtp to version 2.0 Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client. Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits). https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s' 2016-10-20 kjellander Only build libsrtp tests if a build flag is set 2016-10-20 kjellander Don't build tests on Windows. 2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC 2016-10-10 kjellander Make libsrtp configuration public 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=webrtc:6376 Review-Url: https://chromiumcodereview.appspot.com/2436913003 Cr-Commit-Position: refs/heads/master@{#426814} (cherry picked from commit c2eb0266eee3348b00ad3cdc1261d71cefe47333) ========== to ========== Upgrade libsrtp to version 2.0 Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client. Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits). https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s' 2016-10-20 kjellander Only build libsrtp tests if a build flag is set 2016-10-20 kjellander Don't build tests on Windows. 2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC 2016-10-10 kjellander Make libsrtp configuration public 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=625878 Review-Url: https://chromiumcodereview.appspot.com/2436913003 Cr-Commit-Position: refs/heads/master@{#426814} (cherry picked from commit c2eb0266eee3348b00ad3cdc1261d71cefe47333) ==========
On 2016/10/31 20:57:50, mattdr-at-chromium wrote: > On 2016/10/31 20:54:55, kjellander_chromium wrote: > > On 2016/10/31 20:47:13, mattdr-at-chromium wrote: > > > Cherry-pick into release branch. > > > > 2883 is the current beta branch according to https://omahaproxy.appspot.com/. > > To be able to merge to that you need to file a separate bug at > http://crbug.com, link > > to it from this CL and get merge approval for it. > > https://bugs.chromium.org/p/chromium/issues/detail?id=625878#c24 Excellent. Then lgtm
On 2016/10/31 20:59:24, kjellander_chromium wrote: > On 2016/10/31 20:57:50, mattdr-at-chromium wrote: > > On 2016/10/31 20:54:55, kjellander_chromium wrote: > > > On 2016/10/31 20:47:13, mattdr-at-chromium wrote: > > > > Cherry-pick into release branch. > > > > > > 2883 is the current beta branch according to > https://omahaproxy.appspot.com/. > > > To be able to merge to that you need to file a separate bug at > > http://crbug.com, link > > > to it from this CL and get merge approval for it. > > > > https://bugs.chromium.org/p/chromium/issues/detail?id=625878#c24 > > Excellent. Then lgtm (but you need more approvals just like in https://chromiumcodereview.appspot.com/2436913003)
On 2016/10/31 21:00:11, kjellander_chromium wrote: > On 2016/10/31 20:59:24, kjellander_chromium wrote: > > On 2016/10/31 20:57:50, mattdr-at-chromium wrote: > > > On 2016/10/31 20:54:55, kjellander_chromium wrote: > > > > On 2016/10/31 20:47:13, mattdr-at-chromium wrote: > > > > > Cherry-pick into release branch. > > > > > > > > 2883 is the current beta branch according to > > https://omahaproxy.appspot.com/. > > > > To be able to merge to that you need to file a separate bug at > > > http://crbug.com, link > > > > to it from this CL and get merge approval for it. > > > > > > https://bugs.chromium.org/p/chromium/issues/detail?id=625878#c24 > > > > Excellent. Then lgtm > > (but you need more approvals just like in > https://chromiumcodereview.appspot.com/2436913003) <head in hands> fun system y'all have here
mattdr@chromium.org changed reviewers: + brucedawson@chromium.org, inferno@chromium.org
+brucedawson for BUILD.gn +inferno for libfuzzer
On 2016/10/31 21:00:45, mattdr-at-chromium wrote: > On 2016/10/31 21:00:11, kjellander_chromium wrote: > > On 2016/10/31 20:59:24, kjellander_chromium wrote: > > > On 2016/10/31 20:57:50, mattdr-at-chromium wrote: > > > > On 2016/10/31 20:54:55, kjellander_chromium wrote: > > > > > On 2016/10/31 20:47:13, mattdr-at-chromium wrote: > > > > > > Cherry-pick into release branch. > > > > > > > > > > 2883 is the current beta branch according to > > > https://omahaproxy.appspot.com/. > > > > > To be able to merge to that you need to file a separate bug at > > > > http://crbug.com, link > > > > > to it from this CL and get merge approval for it. > > > > > > > > https://bugs.chromium.org/p/chromium/issues/detail?id=625878#c24 > > > > > > Excellent. Then lgtm > > > > (but you need more approvals just like in > > https://chromiumcodereview.appspot.com/2436913003) > > <head in hands> > > fun system y'all have here Well, to be honest I don't know - maybe it's OK to TBR previous reviewers for branch merges? I don't dare saying it's OK though (you could ask a TPM or try digging up some official instructions since I'd be interested to learn).
The CQ bit was checked by awhalley@google.com
The CQ bit was unchecked by awhalley@google.com
The CQ bit was checked by awhalley@google.com
On 2016/10/31 21:05:33, kjellander_chromium wrote: > On 2016/10/31 21:00:45, mattdr-at-chromium wrote: > > On 2016/10/31 21:00:11, kjellander_chromium wrote: > > > On 2016/10/31 20:59:24, kjellander_chromium wrote: > > > > On 2016/10/31 20:57:50, mattdr-at-chromium wrote: > > > > > On 2016/10/31 20:54:55, kjellander_chromium wrote: > > > > > > On 2016/10/31 20:47:13, mattdr-at-chromium wrote: > > > > > > > Cherry-pick into release branch. > > > > > > > > > > > > 2883 is the current beta branch according to > > > > https://omahaproxy.appspot.com/. > > > > > > To be able to merge to that you need to file a separate bug at > > > > > http://crbug.com, link > > > > > > to it from this CL and get merge approval for it. > > > > > > > > > > https://bugs.chromium.org/p/chromium/issues/detail?id=625878#c24 > > > > > > > > Excellent. Then lgtm > > > > > > (but you need more approvals just like in > > > https://chromiumcodereview.appspot.com/2436913003) > > > > <head in hands> > > > > fun system y'all have here > > Well, to be honest I don't know - maybe it's OK to TBR previous reviewers for > branch merges? I don't dare saying it's OK though (you could ask a TPM or try > digging up some official instructions since I'd be interested to learn). LGTM
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== Upgrade libsrtp to version 2.0 Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client. Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits). https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s' 2016-10-20 kjellander Only build libsrtp tests if a build flag is set 2016-10-20 kjellander Don't build tests on Windows. 2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC 2016-10-10 kjellander Make libsrtp configuration public 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=625878 Review-Url: https://chromiumcodereview.appspot.com/2436913003 Cr-Commit-Position: refs/heads/master@{#426814} (cherry picked from commit c2eb0266eee3348b00ad3cdc1261d71cefe47333) ========== to ========== Upgrade libsrtp to version 2.0 Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client. Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits). https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s' 2016-10-20 kjellander Only build libsrtp tests if a build flag is set 2016-10-20 kjellander Don't build tests on Windows. 2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC 2016-10-10 kjellander Make libsrtp configuration public 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=625878 NOTRY=true NOPRESUBMIT=true Review-Url: https://chromiumcodereview.appspot.com/2436913003 Cr-Commit-Position: refs/heads/master@{#426814} (cherry picked from commit c2eb0266eee3348b00ad3cdc1261d71cefe47333) ==========
The CQ bit was checked by mattdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mattdr@chromium.org changed reviewers: - brucedawson@chromium.org, inferno@chromium.org
-others
Message was sent while issue was closed.
Description was changed from ========== Upgrade libsrtp to version 2.0 Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client. Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits). https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s' 2016-10-20 kjellander Only build libsrtp tests if a build flag is set 2016-10-20 kjellander Don't build tests on Windows. 2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC 2016-10-10 kjellander Make libsrtp configuration public 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=625878 NOTRY=true NOPRESUBMIT=true Review-Url: https://chromiumcodereview.appspot.com/2436913003 Cr-Commit-Position: refs/heads/master@{#426814} (cherry picked from commit c2eb0266eee3348b00ad3cdc1261d71cefe47333) ========== to ========== Upgrade libsrtp to version 2.0 Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client. Roll src/third_party/libsrtp/ b17c065a8..71692eaab (5 commits). https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..71692eaab --date=short --no-merges --format='%ad %ae %s' 2016-10-20 kjellander Only build libsrtp tests if a build flag is set 2016-10-20 kjellander Don't build tests on Windows. 2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC 2016-10-10 kjellander Make libsrtp configuration public 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=625878 NOTRY=true NOPRESUBMIT=true Review-Url: https://chromiumcodereview.appspot.com/2436913003 Cr-Commit-Position: refs/heads/master@{#426814} (cherry picked from commit c2eb0266eee3348b00ad3cdc1261d71cefe47333) ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
