Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3049)

Unified Diff: blimp/engine/browser_tests/blimp_browser_test.h

Issue 2462183002: GRPC Stream implementation of HeliumStream
Patch Set: Fixed a few minor comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/browser_tests/blimp_browser_test.h
diff --git a/blimp/engine/browser_tests/blimp_browser_test.h b/blimp/engine/browser_tests/blimp_browser_test.h
index 4f54e84644326aa7af52e6cde42ff7c6270a44c5..6eaca986f124a9fc9a6de4dc4cae97a9d34cf190 100644
--- a/blimp/engine/browser_tests/blimp_browser_test.h
+++ b/blimp/engine/browser_tests/blimp_browser_test.h
@@ -9,6 +9,7 @@
#include "base/synchronization/waitable_event.h"
#include "base/threading/thread_restrictions.h"
+#include "blimp/common/assignment_options.h"
#include "content/public/test/browser_test_base.h"
namespace base {
@@ -65,11 +66,12 @@ class BlimpBrowserTest : public content::BrowserTestBase {
void TearDownOnMainThread() override;
private:
- // Receives the port number from an asynchronously connected socket.
- // Calls SignalCompletion() when set.
- void OnGetEnginePortCompletion(uint16_t port);
+ // Receives the engine assignment after it completes setup to be passed to
+ // the client as is (independent of the specific transport).
+ void OnGetEngineSetupCompletion(AssignmentOptions options);
- uint16_t engine_port_;
+ // Engine assignment options filled after the engine is setup.
+ AssignmentOptions assignment_options_;
// Used to signal the completion of asynchronous processing to
// RunUntilCompletion().

Powered by Google App Engine
This is Rietveld 408576698